Allow copying only a selection of text #2753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoisl
requested changes
May 10, 2021
| @@ -90,9 +91,10 @@ class ReportActionItem extends Component { | |||
| * | |||
| * @param {Object} [event] - A press event. | |||
| */ | |||
| showPopover(event) { | |||
| showPopover(event, selection) { | |||
There was a problem hiding this comment.
Can you add a @param JSDoc for selection please?
| @@ -54,7 +54,7 @@ class ReportActionContextMenu extends React.Component { | |||
| onPress: () => { | |||
| const message = _.last(lodashGet(this.props.reportAction, 'message', null)); | |||
| const html = lodashGet(message, 'html', ''); | |||
| const text = lodashGet(message, 'text', ''); | |||
| const text = props.selection || lodashGet(message, 'text', ''); | |||
There was a problem hiding this comment.
selection needs to be defined in the propTypes
…sify.cash into viacheslav-selectText
|
Updated |
francoisl
approved these changes
May 11, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging in version: 1.0.42-1🚀
|
|
🚀 Deployed to production in version: 1.0.44-0🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
we get selection when the event of contextmenu is triggered. window.getSelection().toString();
Fixed Issues
Fixes #2665
Tests
QA Steps
Same as above
Tested On
Screenshots
Web
https://drive.google.com/uc?export=view&id=1WFtc-t6NuaLDZ1xM016ggYxfCUhxjJUb
Mobile Web
Desktop
https://drive.google.com/uc?export=view&id=1EJUC7rZFNFFCraIcqLDCIJzBGObdMfeN
iOS
Android