Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not send local notifications if preference states so #2725

Merged
merged 2 commits into from
May 19, 2021
Merged

Do not send local notifications if preference states so #2725

merged 2 commits into from
May 19, 2021

Conversation

iwiznia
Copy link
Contributor

@iwiznia iwiznia commented May 6, 2021 •
edited
Loading

Hold on https://github.com/Expensify/Web-Expensify/pull/30875

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/161779

Tests

  • Log in in 2 windows with 2 different users
  • Send a message from one user to the other
  • Check the receiving user got a notification for the new message

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@iwiznia iwiznia requested a review from yuwenmemon May 6, 2021 22:59
@iwiznia iwiznia requested a review from a team as a code owner May 6, 2021 22:59
@iwiznia iwiznia self-assigned this May 6, 2021
@MelvinBot MelvinBot requested review from joelbettner and removed request for a team May 6, 2021 23:00
@iwiznia iwiznia changed the title [HOLD] Do not send local notifications if preference states so Do not send local notifications if preference states so May 19, 2021
@iwiznia
Copy link
Contributor Author

iwiznia commented May 19, 2021

Bump!

yuwenmemon
yuwenmemon requested changes May 19, 2021
View reviewed changes
Copy link
Contributor

@yuwenmemon yuwenmemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can we at least add a test showing that notifications for DMs are still working?

@iwiznia
Copy link
Contributor Author

iwiznia commented May 19, 2021

@yuwenmemon added the test

@yuwenmemon yuwenmemon merged commit e9f2944 into main May 19, 2021
@yuwenmemon yuwenmemon deleted the ionatan_notification_preferences branch May 19, 2021 22:41
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwenmemon yuwenmemon yuwenmemon approved these changes

@joelbettner joelbettner joelbettner approved these changes

Assignees

@iwiznia iwiznia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iwiznia @OSBotify @yuwenmemon @joelbettner