feature: Include polyfill.io for web builds #2722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a custom `HtmlWebpackPlugin` option to only bundle the script for polyfill.io for the web/mWeb platform - it's not needed for desktop as it already works with latest tech The `ResizeObserver` is added as it's not included in the `default` features It's needed for the app to work on iOS 12 mWeb Safari The `gated` flag is added to skip polyfilling a feature that is already supported natively by the browser
692d737 to
1494e3f
Compare
Some timing informationEffects on initial load time for the app First Load on old browser
First Load on a modern browser
Consecutive loads from disk cache
Consecutive loads from memory
First load on 3g network
|
Julesssss
approved these changes
May 7, 2021
|
Tested well on Web/Desktop and an iPhone 12.4 simulator. |
23 tasks
|
🚀 Deployed to staging in version: 1.0.39-3🚀
|
|
🚀 Deployed to production in version: 1.0.39-5🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Julesssss
Details
Provide a custom
HtmlWebpackPluginoption to prevent bundling the script tag that adds polyfill.io on desktopIt's not needed there - desktop already works with latest tech
The script tag that loads polyfill.io is only included on web (and mWeb)
The
ResizeObserveris added as it's not included in thedefaultfeaturesIt's needed for the app to work on iOS 12 mWeb Safari
The
gatedflag is added to skip polyfilling a feature that is already supportednatively by the browser
Fixed Issues
Fixes #2520
Tests
Since I've made changes to the webpack config and the index file that's used for desktop as well please run the same steps on desktop too
No changes to the native platforms
QA Steps
Same as above
Tested On
Screenshots
Web
Mobile Web
Screen.Recording.2021-05-06.at.21.58.16.mov
Desktop