Manually handle keyboard to prevent Android crash

[marcaaron]

Details

Fix Android crash due to automatic handling of software keyboard

Fixed Issues

Fixes #2694

Tests

QA Steps

Repeat steps in linked issue...

1. Launch the app
2. Log in with expensifail account
3. Select any user
4. Click on Plus button and select Request Money
5. Put any amount and Click Next
6. In Field What's it for? - put some text (make sure the software keyboard is displayed)
7. Tap on back arrow
8. Verify the Android app does not crash.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[marcaaron]

cc @Julesssss since I think you might be interested in this fix.

[Julesssss]

the on screen keyboard will NOT automatically dismiss when navigating to a new screen. Defaults to true.

This is working nicely. Given that we are adding the flag to the main nav stack I was worried that the soft keyboard would remain open when navigating to Screens with no input fields (this happens with native Android if you remove the auto-handling and don't manually close the soft keyboard) -- but this doesn't seem to be happening...

This is great, but I'm a bit confused as to why this is -- something must be telling the keyboard to hide and I would love to know what that is (behavior that we've declared elsewhere, or maybe default RN handling that occurs if the screen contains no input?). It's not important enough to block the merge and I don't have the time to investigate the RN/navigation code, but please let me know if you have any theories!

[marcaaron]

something must be telling the keyboard to hide and I would love to know what that is (behavior that we've declared elsewhere, or maybe default RN handling that occurs if the screen contains no input?)

react-navigation was telling it to hide, but now it just hides when the input is unmounted would be my best guess.

[marcaaron]

all yours @ctkochan22

[OSBotify]

🚀 Deployed to staging in version: 1.0.39-1🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production in version: 1.0.39-5🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅