-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SDK token endpoints for Wallet KYC #2692
Conversation
@timszot Adding you as a reviewer since you got pullerbeared on https://github.com/Expensify/Web-Secure/pull/1934 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks straightforward. Approving.
Taking this one off hold and merging now that the web-secure stuff is on production. Thanks @timszot ! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging in version: 1.0.41-0🚀
|
🚀 Deployed to production in version: 1.0.44-0🚀
|
Details
Holding on the Web-Secure PR here which should be deployed to production before we remove the HOLD here.
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/161730
Fixes https://github.com/Expensify/Expensify/issues/161730
Tests
This can be tested by forcing the APIs being added to run and verifying they are able to access Web-Secure. Although, it's not totally necessary as they are not used in the code yet. Here's what I did:
window
at the bottom ofAPI.js
e.g.QA Steps
No QA
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android