Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDK token endpoints for Wallet KYC #2692

Merged
merged 3 commits into from
May 7, 2021
Merged

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented May 5, 2021

Details

Holding on the Web-Secure PR here which should be deployed to production before we remove the HOLD here.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/161730
Fixes https://github.com/Expensify/Expensify/issues/161730

Tests

This can be tested by forcing the APIs being added to run and verifying they are able to access Web-Secure. Although, it's not totally necessary as they are not used in the code yet. Here's what I did:

  1. made both of these commands globally accessible by sticking them on window at the bottom of API.js e.g.
window.Wallet_GetOnfidoSDKToken = Wallet_GetOnfidoSDKToken;
window.Plaid_GetLinkToken = Plaid_GetLinkToken;
  1. Then called each one from the JS console like this
Wallet_GetOnfidoSDKToken().then(res => console.log(res));
Plaid_GetLinkToken().then(res => console.log(res));
  1. Verified they returned a response with the tokens

QA Steps

No QA

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron self-assigned this May 5, 2021
@marcaaron marcaaron requested a review from timszot May 5, 2021 00:25
@marcaaron
Copy link
Contributor Author

@timszot Adding you as a reviewer since you got pullerbeared on https://github.com/Expensify/Web-Secure/pull/1934

@marcaaron marcaaron marked this pull request as ready for review May 5, 2021 00:29
@marcaaron marcaaron requested a review from a team as a code owner May 5, 2021 00:29
@marcaaron marcaaron removed the request for review from a team May 5, 2021 00:30
@MelvinBot MelvinBot requested a review from Beamanator May 5, 2021 00:30
Copy link
Contributor

@timszot timszot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward. Approving.

@marcaaron marcaaron changed the title [HOLD Web-S] Add SDK token endpoints for Wallet KYC Add SDK token endpoints for Wallet KYC May 7, 2021
@marcaaron
Copy link
Contributor Author

Taking this one off hold and merging now that the web-secure stuff is on production. Thanks @timszot !

@marcaaron marcaaron merged commit 7423dc0 into main May 7, 2021
@marcaaron marcaaron deleted the marcaaron-addKYCAPIs branch May 7, 2021 20:03
@OSBotify
Copy link
Contributor

OSBotify commented May 7, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented May 8, 2021

🚀 Deployed to staging in version: 1.0.41-0🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.44-0🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants