Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO QA] Remove up unused Timing key #2681

Merged
merged 1 commit into from
May 4, 2021
Merged

Conversation

Julesssss
Copy link
Contributor

@Julesssss Julesssss commented May 4, 2021

Details

Simply removes a deprecated timing key that was not previously cleaned up. The related dashboard is also being removed.

Fixed Issues

N/A, this is simply deleting a key.

Tests

  • Run the app
  • Switch report
  • Ensure no errors show in the console

QA Steps

N/A -- see above

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@Julesssss Julesssss requested a review from a team May 4, 2021 10:31
@Julesssss Julesssss self-assigned this May 4, 2021
@MelvinBot MelvinBot requested review from MariaHCD and removed request for a team May 4, 2021 10:32
@MariaHCD MariaHCD merged commit 04a7e60 into main May 4, 2021
@MariaHCD MariaHCD deleted the jules-cleanUpUnusedTimingKey branch May 4, 2021 11:15
@OSBotify
Copy link
Contributor

OSBotify commented May 4, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented May 4, 2021

🚀 Deployed to staging in version: 1.0.36-1🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented May 8, 2021

🚀 Deployed to production in version: 1.0.39-5🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants