[No QA] Make BootSplash have better parity on web/desktop #2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoisl
approved these changes
Apr 29, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
23 tasks
|
🚀 Deployed to staging in version: 1.0.34-1🚀
|
|
🚀 Deployed to production in version: 1.0.39-5🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
react-native-bootsplash returns a void promise for
hide,show, and a promise that resolves to one of"visible","hidden","transitioning"forgetVisibilityStatus. This PR just improves the parity in our web shim so that we don't have another problem like the one solved by this PRFixed Issues
n/a
Tests
Just do some basic regression testing to make sure the app still runs okay and doesn't have any console warnings.
Tested On