-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IOU Menu Options #2612
Add IOU Menu Options #2612
Conversation
Will add screenshots and test on all platforms in a bit but wanted to get this into review sooner than later. |
This PR shouldn't really have any effects on the way things are working there. But I think if you click to the right of the USD then you can enter a number and should be able to "Next" after that. I found this a little confusing myself as the view doesn't really look like an input of any kind so it's unclear what we can do on desktop. |
Oh derp, got it... I was expecting the view would directly show the bill participants. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue tests well.
One request, would you mind removing the other 'Hiding menu options' comment here, as this PR makes it irrelevant.
Also, could you add a test case for confirming that the IOU beta flag is working as expected in the description? (I was able to test this locally by removing the all
beta flag, but for QA we should probably use accounts with/without the flag to verify)
Thanks for spotting that @Julesssss! I have made that requested change and added a test step to verify the new options do not appear for non beta users. |
Are we good to go here without @Julesssss re-review so we can get testing, as I think he's out for the evening now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this change will not invalidate the tests I ran earlier. Merging
I can't find the merge button on the GitHub app, but we're good to go. Feel free to merge |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging in version: 1.0.34-1🚀
|
Details
cc @Julesssss @iwiznia adds the menu options behind beta
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/161984
Tests
QA Steps
+
menu next to the comment compose areaRequest Money
+
menu next to the comment compose areaSplit Bill
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android