Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: profile scroll #2596

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Apr 27, 2021

Please review.

Details

Added ScrollView around the ProfilePage content.

Fixed Issues

Fixes #2147

Tests / QA Steps

  1. Try to scroll the Profile page.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web / Mobile Web / Desktop

desk-scroll.mp4

iOS

Android

1619549008886.mp4

@parasharrajat parasharrajat requested a review from a team as a code owner April 27, 2021 18:46
@MelvinBot MelvinBot requested review from pecanoro and removed request for a team April 27, 2021 18:46
@pecanoro pecanoro merged commit 6bf8368 into Expensify:main Apr 27, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.32-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented May 8, 2021

🚀 Deployed to production in version: 1.0.39-5🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the parasharrajat/profile branch November 20, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS/Android - Profile page does not scroll
3 participants