Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show environment badge next to chats header #2593

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Only show environment badge next to chats header #2593

merged 1 commit into from
Apr 28, 2021

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Apr 27, 2021

@Julesssss will you please review this?

Details

This PR removes the environment badges from modals in e.cash which were added in this PR

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/161818

  1. Run the app on dev on all platforms and sign in, confirm you see a dev badge next to the Chats header.
  2. Open the settings modal, confirm you don't see a dev badge

QA Steps

  1. When running the app on staging, confirm the STG badge shows next to the Chats header when signed in.
  2. Open the settings modal, confirm you don't see a badge next to Settings

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

image
image
image

@Jag96 Jag96 requested a review from Julesssss April 27, 2021 17:38
@Jag96 Jag96 requested a review from a team as a code owner April 27, 2021 17:38
@Jag96 Jag96 self-assigned this Apr 27, 2021
@MelvinBot MelvinBot requested review from sketchydroide and removed request for a team April 27, 2021 17:38
Julesssss
Julesssss approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Julesssss Julesssss merged commit 7f02828 into main Apr 28, 2021
@Julesssss Julesssss deleted the joe-update-badges branch April 28, 2021 11:24
@OSBotify OSBotify mentioned this pull request Apr 28, 2021
Closed
66 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.32-2🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julesssss Julesssss Julesssss approved these changes

@sketchydroide sketchydroide Awaiting requested review from sketchydroide

Assignees

@Jag96 Jag96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jag96 @OSBotify @Julesssss