Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Apply localization to all hard coded text" #2579

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Revert "Apply localization to all hard coded text" #2579

merged 1 commit into from
Apr 26, 2021

Conversation

iwiznia
Copy link
Contributor

@iwiznia iwiznia commented Apr 26, 2021

Reverts #2562

cc @eVoloshchak

See review here

@iwiznia iwiznia requested a review from Luke9389 April 26, 2021 21:36
@iwiznia iwiznia requested a review from a team as a code owner April 26, 2021 21:36
@iwiznia iwiznia self-assigned this Apr 26, 2021
@MelvinBot MelvinBot requested review from pecanoro and removed request for a team April 26, 2021 21:37
@iwiznia iwiznia added the DeployBlockerCash This issue or pull request should block deployment label Apr 26, 2021
@OSBotify OSBotify mentioned this pull request Apr 26, 2021
Closed
66 tasks
@iwiznia
Copy link
Contributor Author

iwiznia commented Apr 26, 2021

I don't know why puller bear got involved here and there seems to be a bug in GH because I can't seem to unassign @pecanoro... anyway, you can ignore this @pecanoro

@iwiznia iwiznia added 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging and removed DeployBlockerCash This issue or pull request should block deployment labels Apr 26, 2021
@Luke9389 Luke9389 merged commit 9413aba into main Apr 26, 2021
@Luke9389 Luke9389 deleted the revert-2562-eVoloshchak-localizedStrings branch April 26, 2021 22:07
@AndrewGable AndrewGable removed the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Apr 26, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.31-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented May 8, 2021

🚀 Deployed to production in version: 1.0.39-5🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luke9389 Luke9389 Luke9389 approved these changes

@pecanoro pecanoro Awaiting requested review from pecanoro

Assignees

@iwiznia iwiznia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iwiznia @OSBotify @Luke9389 @AndrewGable