Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Get bankAccountList to verify secure endpoints will work #2578

Merged
merged 2 commits into from
May 4, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Apr 26, 2021

Details

This PR must wait until https://github.com/Expensify/Web-Secure/pull/1927 is on production then it can be tested on both staging and production later

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/161728

Tests

  1. Add EXPENSIFY_URL_SECURE=https://secure.expensify.com.dev/ to your .env file
  2. Login and inspect the network panel in Chrome Dev Tools
  3. Locate a Get request with returnValueList: 'bankAccountList' and verify that it succeeded and has an OK response
    Screen Shot 2021-04-26 at 11 11 37 AM
    Screen Shot 2021-04-26 at 11 11 03 AM

QA Steps

  1. Locate a Get request with returnValueList: 'bankAccountList' and verify that it succeeded and has an OK response

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron self-assigned this Apr 26, 2021
@marcaaron marcaaron changed the title Add Get bankAccountList to verify secure endpoints will work [HOLD] Add Get bankAccountList to verify secure endpoints will work Apr 26, 2021
@marcaaron marcaaron marked this pull request as ready for review April 26, 2021 22:17
@marcaaron marcaaron requested a review from a team as a code owner April 26, 2021 22:17
@marcaaron marcaaron removed the request for review from a team April 26, 2021 22:17
@MelvinBot MelvinBot requested a review from Beamanator April 26, 2021 22:17
@marcaaron marcaaron changed the title [HOLD] Add Get bankAccountList to verify secure endpoints will work Add Get bankAccountList to verify secure endpoints will work May 4, 2021
@marcaaron
Copy link
Contributor Author

Taking this one off HOLD now that the web-secure PR is on production

Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Worked well for me, tested on Desktop 👍

I'd recommend adding a testing step like "Add EXPENSIFY_URL_SECURE=https://secure.expensify.com.dev/ to your .env file" :)

Copy link
Contributor

@nickmurray47 nickmurray47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and tests well too, +1 on the above test step

@marcaaron marcaaron merged commit 363b474 into main May 4, 2021
@marcaaron marcaaron deleted the marcaaron-secureEndpointTest branch May 4, 2021 23:59
@OSBotify
Copy link
Contributor

OSBotify commented May 5, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented May 5, 2021

🚀 Deployed to staging in version: 1.0.37-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented May 8, 2021

🚀 Deployed to production in version: 1.0.39-5🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants