-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Get bankAccountList to verify secure endpoints will work #2578
Conversation
Taking this one off HOLD now that the web-secure PR is on production |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Worked well for me, tested on Desktop 👍
I'd recommend adding a testing step like "Add EXPENSIFY_URL_SECURE=https://secure.expensify.com.dev/
to your .env
file" :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm and tests well too, +1 on the above test step
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging in version: 1.0.37-1🚀
|
🚀 Deployed to production in version: 1.0.39-5🚀
|
Details
This PR must wait until https://github.com/Expensify/Web-Secure/pull/1927 is on production then it can be tested on both staging and production later
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/161728
Tests
EXPENSIFY_URL_SECURE=https://secure.expensify.com.dev/
to your.env
fileGet
request withreturnValueList: 'bankAccountList'
and verify that it succeeded and has an OK responseQA Steps
Get
request withreturnValueList: 'bankAccountList'
and verify that it succeeded and has an OK responseTested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android