-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[navigation-refactor] Fix browser history for complex navigation actions" #25572
Conversation
This is happening due to multiple race conditions between |
I have fixed this issue. Can I put the patch PR? |
🧪🧪 Use the links below to test this build in android and iOS. Happy testing! 🧪🧪 |
@mountiny are you gonna revert the revert? |
@hayata-suenaga not sure what you mean, I have created this revert branch to make sure if it would fix the issues but I have confirmed the issues linked to the Pr still prevailed so it was not the root cause. No need to revert |
@mountiny I have an issue that was being held for the original PR. Since you reverted the original PR (but confirmed that it was not the root cause of an issue), I was wondering if you're planning to bring back the original PR by reverting this revert PR. |
Probably some miscommunication, the PR was not reverted. This Revert PR has not been merged so the original PR is still there |
So not only Big Green buttons but also big red signs |
at this point, I'm terrified of any buttons and signs in general 😆 |
Reverts #24165