Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[navigation-refactor] Fix browser history for complex navigation actions" #25572

Closed
wants to merge 1 commit into from

Conversation

mountiny
Copy link
Contributor

Reverts #24165

@shubham1206agra
Copy link
Contributor

This is happening due to multiple race conditions between window.history methods and the onStateChange method execution. Due to which, multiple window.history.go(-1) calls were made, and #25527 occurs

@shubham1206agra
Copy link
Contributor

This is happening due to multiple race conditions between window.history methods and the onStateChange method execution. Due to which, multiple window.history.go(-1) calls were made, and #25527 occurs

I have fixed this issue. Can I put the patch PR?

@mountiny
Copy link
Contributor Author

@OSBotify
Copy link
Contributor

@hayata-suenaga
Copy link
Contributor

@mountiny are you gonna revert the revert?

@mountiny
Copy link
Contributor Author

@hayata-suenaga not sure what you mean, I have created this revert branch to make sure if it would fix the issues but I have confirmed the issues linked to the Pr still prevailed so it was not the root cause. No need to revert

@hayata-suenaga
Copy link
Contributor

@mountiny I have an issue that was being held for the original PR. Since you reverted the original PR (but confirmed that it was not the root cause of an issue), I was wondering if you're planning to bring back the original PR by reverting this revert PR.

@mountiny
Copy link
Contributor Author

Probably some miscommunication, the PR was not reverted. This Revert PR has not been merged so the original PR is still there

@hayata-suenaga
Copy link
Contributor

ahh can't believe I missed this big red sign 😓 thank you for much for the clarification 🙇

Screenshot 2023-08-22 at 1 19 13 PM

@mountiny
Copy link
Contributor Author

So not only Big Green buttons but also big red signs :trollface:

@hayata-suenaga
Copy link
Contributor

at this point, I'm terrified of any buttons and signs in general 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants