Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO QA] Fix spelling #2529

Merged
merged 1 commit into from
Apr 22, 2021
Merged

[NO QA] Fix spelling #2529

merged 1 commit into from
Apr 22, 2021

Conversation

jasperhuangg
Copy link
Contributor

Details

The route name for secondary login add was spelled wrong. Let's use the correct spelling.

Tests

N/A

QA Steps

N/A

@jasperhuangg jasperhuangg self-assigned this Apr 22, 2021
@jasperhuangg jasperhuangg marked this pull request as ready for review April 22, 2021 04:29
@jasperhuangg jasperhuangg requested a review from a team as a code owner April 22, 2021 04:29
@MelvinBot MelvinBot requested review from deetergp and removed request for a team April 22, 2021 04:29
deetergp
deetergp approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@deetergp deetergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deetergp deetergp merged commit d27cf29 into main Apr 22, 2021
@deetergp deetergp deleted the jasper-fixSecondaryLoginSpelling branch April 22, 2021 23:53
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented May 8, 2021

🚀 Deployed to production in version: 1.0.39-5🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deetergp deetergp deetergp approved these changes

@robertjchen robertjchen robertjchen approved these changes

Assignees

@jasperhuangg jasperhuangg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasperhuangg @OSBotify @deetergp @robertjchen