Fix CreateMenu and mobile safari attachment picker #2516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR and this PR made updates to an old version of
CreateMenu, essentially missing the changes introduced to the component here.Since we had two competing modules,
src/components/CreateMenu/andsrc/components/CreateMenu.js, the latter was being used and the fixes to the attachment picker introduced here were not taking effect.This PR combines the histories of these two modules and creates a single
CreateMenucomponent.Fixed Issues
Fixes (regression comment) #2460 (comment)
Tests / QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android