[No QA] Include app version in PR deploy comments #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewGable
reviewed
Apr 21, 2021
.github/actions/markPullRequestsAsDeployed/markPullRequestsAsDeployed.js
Outdated
Show resolved
Hide resolved
AndrewGable
reviewed
Apr 21, 2021
…eployed.js Co-authored-by: Andrew Gable <andrew@expensify.com>
Co-authored-by: Andrew Gable <andrew@expensify.com>
|
Good catches! Updated! |
|
Can you rebuild actions? |
|
Updated! |
ctkochan22
approved these changes
Apr 22, 2021
AndrewGable
approved these changes
Apr 22, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production in version: 1.0.39-5🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Adds the app version to the deploy comments in PRs
Fixed Issues
No issue, just noticed this when looking at some regressions here that it would be nice to definitively know in which version the PR was deployed.
Tests
StagingDeployCashis not locked to test