Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change screen name of SignIn route to "Home" #2509

Merged
merged 11 commits into from
Apr 27, 2021

Conversation

jasperhuangg
Copy link
Contributor

@jasperhuangg jasperhuangg commented Apr 21, 2021

Details

See issue for more context.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/161155

Tests

  • Verified that for an unauthenticated account, the SignIn page is still the first thing that loads (and that there are no issues when rendering the component.
  • Verified that you can sign in and that you're taken to the chat hoe
  • Verified that you can sign out and that you're taken back to the sign in page.
  • Verified that the flow for validating a secondary login still works.

QA Steps

  1. Sign out of any accounts. On mobile/desktop, simply open the app. On web, navigate to the root URL.
  2. Verify that sign in page renders.
  3. Verify that you can log in and that it redirects you to the chat home.
  4. Verify that you can sign out and that it redirects you back to the sign in page.
  5. Validate a secondary login and verify that the validation link works as expected (see QA steps for https://github.com/Expensify/Web-Expensify/pull/30615 for additional details).

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-04-21 at 1 11 07 PM

Mobile Web

simulator_screenshot_6036C218-CDD3-4957-BCBF-4DC2C7F47D44

Desktop

Screen Shot 2021-04-21 at 1 12 35 PM

iOS

Simulator Screen Shot - iPhone 11 - 2021-04-21 at 13 07 15

Android

Screenshot_1618981772

cc @NikkiWines

@jasperhuangg jasperhuangg self-assigned this Apr 21, 2021
@jasperhuangg jasperhuangg requested review from marcaaron and removed request for marcaaron April 21, 2021 02:53
@jasperhuangg
Copy link
Contributor Author

Hey @NikkiWines! Do you mind verifying/providing context about Marc's comment here:
https://github.com/Expensify/Expensify/issues/161155#issuecomment-823737808

Thanks!

Copy link
Contributor

@marcaaron marcaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but have a couple comments

@jasperhuangg jasperhuangg requested a review from marcaaron April 26, 2021 04:35
@marcaaron
Copy link
Contributor

@jasperhuangg let us know if this is ready for review by taking it out of draft mode, thanks.

@jasperhuangg jasperhuangg marked this pull request as ready for review April 27, 2021 00:48
@jasperhuangg jasperhuangg requested a review from a team as a code owner April 27, 2021 00:48
@MelvinBot MelvinBot requested review from joelbettner and removed request for a team April 27, 2021 00:49
@marcaaron marcaaron merged commit bf3e258 into main Apr 27, 2021
@marcaaron marcaaron deleted the jasper-signInScreenNameHome branch April 27, 2021 18:22
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.32-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented May 8, 2021

🚀 Deployed to production in version: 1.0.39-5🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants