[No QA] Fix bugs found with staging deploy comments #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roryabraham
requested changes
Apr 19, 2021
| const priorTagIndex = _.indexOf(tags, inputTag) + 1; | ||
|
|
||
| if (priorTagIndex === 0) { | ||
| console.log(`No ${itemToFetch} was found for input tag ${inputTag}. |
There was a problem hiding this comment.
I think this will end up having a weird newline in the middle
|
|
||
| if (priorTagIndex === tags.length) { | ||
| const err = new Error('Somehow, the input tag was at the end of the paginated result, ' | ||
| + "so we don't have the prior tag."); |
There was a problem hiding this comment.
Suggested change
| + "so we don't have the prior tag."); | |
| + 'so we don't have the prior tag.'); |
|
|
||
| return GitUtils.getPullRequestsMergedBetween(priorTag, inputTag); | ||
| }) | ||
| .then(pullRequestList => core.setOutput('PR_LIST', pullRequestList)) |
There was a problem hiding this comment.
Let's also log the list of PRs we found here
roryabraham
approved these changes
Apr 20, 2021
66 tasks
|
🚀 Deployed to staging 🚀
|
|
Nice, this seemed to work! |
|
Oops, we broke prod deploys https://github.com/Expensify/Expensify.cash/runs/2471474181?check_suite_focus=true 😬 |
|
Fix here |
|
🚀 Deployed to production in version: 1.0.39-5🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We found a few bugs with the staging deploy comments, this hopefully resolves all of them:
IS_PRODUCTION_DEPLOYflag to only comment on relevant PRs for staging or production deploysFixed Issues
Fixes 🐛 s!
Tests