-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix react-navigation drawer history issues on web/mWeb #2458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, but testing I noticed that, though it does work as advertised, the highlighting showing which chat you are on does not follow suit. Is that a blocker for this PR or is it a different problem?
chatHistory.mp4
I think so, since it's technically a regression from how things work now. Lemme take a quick look. I think I know why it happens. |
Updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:chefkiss:
LGTM!
chatHistory2.mp4
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production in version: 1.0.39-5🚀
|
Details
This PR adds a custom action to use with react-navigation when navigating to report routes. This is necessary since the default behavior on web and mobile web is to call
window.history.replaceState()
in most cases since navigating to theReport
screen with new params does not add an entry to the history stack.There might be a way to propose a fix for this in
react-navigation
itself, but I'm unsure whether this is the intended behavior and for now this gives us the desired behavior.react-navigation
is intended to be extensible so I'm assuming this solution is OK.Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/157550
Fixes #2028
Tests
QA Steps (web, mobile-web)
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android