Show reply in thread for IOU and Task. #24412

hungvu193 · 2023-08-11T09:40:56Z

Details

Show reply in thread for IOU and Task.

Fixed Issues

$ #23377
PROPOSAL: #23377 (comment)

Tests

Login with any account.
Try to request money to any account.
Hover on the money request.
Verify that there's option for reply in thread.
Create a new task.
Click to From... in header to go to parent report.
Hover on the task that you just created.
Verify that's there's option for reply in thread.

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Login with any account.
Try to request money to any account.
Hover on the money request.
Verify that there's option for reply in thread.
Create a new task.
Click to From... in header to go to parent report.
Hover on the task that you just created.
Verify that's there's option for reply in thread.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-11.at.17.14.19.mov

Mobile Web - Chrome

crhome.mov

Mobile Web - Safari

safa.mov

Desktop

Screen.Recording.2023-08-11.at.17.14.19.mov

iOS

Screen.Recording.2023-08-11.at.17.46.57.mov

Android

trim.mov

Screen.Recording.2023-08-11.at.18.01.38.mov

melvin-bot · 2023-08-11T11:03:46Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2023-08-11T11:04:27Z

@situchan PR is ready for review, please have a look. Ty 😄

hungvu193 · 2023-08-11T11:05:26Z

src/pages/home/report/ContextMenu/ContextMenuActions.js

+            type === CONTEXT_MENU_TYPES.REPORT_ACTION &&
+            ((reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT && !ReportUtils.isThreadFirstChat(reportAction, reportID)) ||
+                reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.REPORTPREVIEW ||
+                reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.IOU),


I don't write a util function here because we're using ReportUtils in our condition, if I move this to util function of ReportActionsUtils it will cause the dependency cycle.

hungvu193 · 2023-08-14T07:48:32Z

src/pages/home/report/ContextMenu/ContextMenuActions.js

@@ -120,7 +120,11 @@ export default [
        successTextTranslateKey: '',
        successIcon: null,
        shouldShow: (type, reportAction, isArchivedRoom, betas, anchor, isChronosReport, reportID) =>
-            type === CONTEXT_MENU_TYPES.REPORT_ACTION && reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT && !ReportUtils.isThreadFirstChat(reportAction, reportID),
+            type === CONTEXT_MENU_TYPES.REPORT_ACTION &&
+            !ReportActionUtils.isSplitBillAction(reportAction) &&


Because we're showing the detail page when clicking on Split IOU, we shouldn't show the thread for split IOU as well.

hungvu193 · 2023-08-15T05:36:36Z

Bump @situchan

src/pages/home/report/ContextMenu/ContextMenuActions.js

situchan · 2023-08-15T17:24:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web1.mov

web2.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

situchan

LGTM

Julesssss · 2023-08-15T20:09:20Z

src/pages/home/report/ContextMenu/ContextMenuActions.js

+            ((reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT && !ReportUtils.isThreadFirstChat(reportAction, reportID)) ||
+                reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.REPORTPREVIEW ||
+                (reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && !ReportActionUtils.isSplitBillAction(reportAction))),


Can we split this into a separate bool to make it easier to read please

Updated @Julesssss !

situchan · 2023-08-16T04:58:00Z

src/pages/home/report/ContextMenu/ContextMenuActions.js

+            const isNormalAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT && !ReportUtils.isThreadFirstChat(reportAction, reportID);
+            const isPreviewAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.REPORTPREVIEW;
+            const isIOUAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && !ReportActionUtils.isSplitBillAction(reportAction);
+            return type === CONTEXT_MENU_TYPES.REPORT_ACTION && (isNormalAction || isPreviewAction || isIOUAction);


if (type !== CONTEXT_MENU_TYPES.REPORT_ACTION) return earlier

isNormalAction -> isCommentAction
isPreviewAction -> isReportPreviewAction (as task preview is also preview)

situchan · 2023-08-16T06:27:42Z

src/pages/home/report/ContextMenu/ContextMenuActions.js

-            type === CONTEXT_MENU_TYPES.REPORT_ACTION && reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT && !ReportUtils.isThreadFirstChat(reportAction, reportID),
+        shouldShow: (type, reportAction, isArchivedRoom, betas, anchor, isChronosReport, reportID) => {
+            if (type !== CONTEXT_MENU_TYPES.REPORT_ACTION) {
+                return;


Suggested change

return;

return false;

github-actions · 2023-08-16T06:30:31Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

situchan · 2023-08-16T07:06:10Z

@hungvu193 what happened with signature? @benjaminbennet is this your account?

hungvu193 · 2023-08-16T07:07:47Z

@hungvu193 what happened with signature? @benjaminbennet is this your account?

I've just borrowed my friend laptop to commit because my laptop was broken 🤦 , brb in couple of minutes.

hungvu193 · 2023-08-16T07:10:49Z

Should be working now. Hmm, not sure why, my laptop was hang when I tried to run npm 🤦 , sorry for this inconvenience @situchan

add condition for split bill action makes iou repliable, sign commit. add condition for split bill action Update src/pages/home/report/ContextMenu/ContextMenuActions.js Co-authored-by: Situ Chandra Shil <108292595+situchan@users.noreply.github.com> optimize variable name update sign commit, var name and early return sign commit email

situchan

LGTM
@Julesssss all yours

Julesssss

Nice, thanks!

OSBotify · 2023-08-16T15:25:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-17T02:20:40Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-21T22:27:13Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.56-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-24T03:10:14Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

eVoloshchak · 2023-11-06T20:35:57Z

src/pages/home/report/ContextMenu/ContextMenuActions.js

+            const isCommentAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT && !ReportUtils.isThreadFirstChat(reportAction, reportID);
+            const isReportPreviewAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.REPORTPREVIEW;
+            const isIOUAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && !ReportActionUtils.isSplitBillAction(reportAction);
+            return isCommentAction || isReportPreviewAction || isIOUAction;


Coming from #29342, "paid elsewhere" message had a "reply in thread message"
We resolved this by moving ReportUtils.isThreadFirstChat

- const isCommentAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT && !ReportUtils.isThreadFirstChat(reportAction, reportID); + const isCommentAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT; - return isCommentAction || isReportPreviewAction || isIOUAction; + return (isCommentAction || isReportPreviewAction || isIOUAction) && !ReportUtils.isThreadFirstChat(reportAction, reportID);

hungvu193 marked this pull request as ready for review August 11, 2023 11:03

hungvu193 requested a review from a team as a code owner August 11, 2023 11:03

melvin-bot bot requested review from situchan and removed request for a team August 11, 2023 11:03

hungvu193 commented Aug 11, 2023

View reviewed changes

hungvu193 commented Aug 14, 2023

View reviewed changes

situchan reviewed Aug 15, 2023

View reviewed changes

src/pages/home/report/ContextMenu/ContextMenuActions.js Outdated Show resolved Hide resolved

situchan approved these changes Aug 15, 2023

View reviewed changes

melvin-bot bot requested a review from Julesssss August 15, 2023 17:42

Julesssss assigned hungvu193 Aug 15, 2023

Julesssss reviewed Aug 15, 2023

View reviewed changes

situchan reviewed Aug 16, 2023

View reviewed changes

hungvu193 force-pushed the fix-23377 branch from 1fd48a6 to e0d949a Compare August 16, 2023 06:28

hungvu193 force-pushed the fix-23377 branch 5 times, most recently from b165148 to 7e2e668 Compare August 16, 2023 06:49

hungvu193 force-pushed the fix-23377 branch from 5048072 to e2ed67b Compare August 16, 2023 07:11

situchan approved these changes Aug 16, 2023

View reviewed changes

melvin-bot bot requested a review from Julesssss August 16, 2023 07:13

Julesssss approved these changes Aug 16, 2023

View reviewed changes

Julesssss merged commit b9a531d into Expensify:main Aug 16, 2023

OSBotify mentioned this pull request Aug 17, 2023

Deploy Checklist: New Expensify 2023-08-17 #25160

Closed

75 tasks

OSBotify mentioned this pull request Aug 21, 2023

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

melvin-bot bot mentioned this pull request Aug 21, 2023

[HOLD for payment 2023-08-28] [$1000] ReportPreview has replies, but there's no option to reply in thread when hovering. #23377

Closed

6 tasks

marcaaron mentioned this pull request Aug 23, 2023

[HOLD for payment 2023-09-04] Task -App becomes unresponsive when Assign Task to user that doesn't have a NewDot account yet #25688

Closed

6 tasks

eVoloshchak reviewed Nov 6, 2023

View reviewed changes

eVoloshchak mentioned this pull request Nov 6, 2023

[HOLD for payment 2023-11-02] [$500] Chat - Reply in thread show on first thread message #29342

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show reply in thread for IOU and Task. #24412

Show reply in thread for IOU and Task. #24412

hungvu193 commented Aug 11, 2023 •

edited

Loading

melvin-bot bot commented Aug 11, 2023

hungvu193 commented Aug 11, 2023

hungvu193 Aug 11, 2023

hungvu193 Aug 14, 2023

hungvu193 commented Aug 15, 2023

situchan commented Aug 15, 2023 •

edited

Loading

situchan left a comment

Julesssss Aug 15, 2023

hungvu193 Aug 16, 2023

hungvu193 Aug 16, 2023

situchan Aug 16, 2023

situchan Aug 16, 2023

situchan Aug 16, 2023

github-actions bot commented Aug 16, 2023 •

edited

Loading

situchan commented Aug 16, 2023

hungvu193 commented Aug 16, 2023

hungvu193 commented Aug 16, 2023

situchan left a comment

Julesssss left a comment

OSBotify commented Aug 16, 2023

OSBotify commented Aug 17, 2023

OSBotify commented Aug 21, 2023

OSBotify commented Aug 24, 2023

eVoloshchak Nov 6, 2023

Show reply in thread for IOU and Task. #24412

Show reply in thread for IOU and Task. #24412

Conversation

hungvu193 commented Aug 11, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 11, 2023

hungvu193 commented Aug 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hungvu193 commented Aug 15, 2023

situchan commented Aug 15, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

situchan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Aug 16, 2023 • edited Loading

situchan commented Aug 16, 2023

hungvu193 commented Aug 16, 2023

hungvu193 commented Aug 16, 2023

situchan left a comment

Choose a reason for hiding this comment

Julesssss left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 16, 2023

OSBotify commented Aug 17, 2023

OSBotify commented Aug 21, 2023

OSBotify commented Aug 24, 2023

Choose a reason for hiding this comment

hungvu193 commented Aug 11, 2023 •

edited

Loading

situchan commented Aug 15, 2023 •

edited

Loading

github-actions bot commented Aug 16, 2023 •

edited

Loading