Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding the link back #2439

Merged
merged 4 commits into from
Apr 23, 2021
Merged

adding the link back #2439

merged 4 commits into from
Apr 23, 2021

Conversation

sketchydroide
Copy link
Contributor

@sketchydroide sketchydroide commented Apr 16, 2021 •
edited
Loading

<If necessary, assign reviewers that know the area or changes well. Feel free to tag any additional reviewers you see fit.>

Details

Adding back the link to UpWork.

Fixed Issues

https://github.com/Expensify/Expensify/issues/158833

Tests

On Web

  1. Open expensi.cash on the login page
  2. Verify that you see the copy "" and the link to upworks.

QA Steps

Same as normal tests

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2021-04-23 at 13 43 54

Mobile Web

Simulator Screen Shot - iPhone 11 - 2021-04-23 at 14 45 29

Desktop

Screenshot 2021-04-23 at 14 43 36

iOS

Simulator Screen Shot - iPhone 11 - 2021-04-23 at 14 32 20

Android

Screenshot_1619185301

@sketchydroide sketchydroide self-assigned this Apr 16, 2021
@sketchydroide sketchydroide requested a review from a team as a code owner April 16, 2021 16:53
@sketchydroide sketchydroide marked this pull request as draft April 16, 2021 16:53
@MelvinBot MelvinBot requested review from nkuoch and removed request for a team April 16, 2021 16:53
@stitesExpensify stitesExpensify requested review from a team and removed request for nkuoch April 20, 2021 19:23
@MelvinBot MelvinBot requested review from deetergp and removed request for a team April 20, 2021 19:23
@sketchydroide sketchydroide marked this pull request as ready for review April 23, 2021 13:46
deetergp
deetergp approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@deetergp deetergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

NAB: but why do we need to different views for wide and narrow?

@deetergp deetergp merged commit 064d9d7 into main Apr 23, 2021
@deetergp deetergp deleted the afonseca_adding_upworks_link_back branch April 23, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deetergp deetergp deetergp approved these changes

Assignees

@sketchydroide sketchydroide

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sketchydroide @deetergp