Done button is not present to close keyboard #2371 #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgolen
requested changes
Apr 20, 2021
|
updated |
tgolen
requested changes
Apr 21, 2021
|
all updated! |
tgolen
approved these changes
Apr 21, 2021
|
Oops, sorry @pecanoro I didn't realize there was another reviewer. If Rocio finds any issues, please submit them in a new PR. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
pecanoro
reviewed
Apr 21, 2021
| @@ -0,0 +1,31 @@ | |||
| /** | |||
| * This is a KeyboardAvoidingView only enabled for ios && disabled for all other platforms | |||
There was a problem hiding this comment.
Hmm, is this one only for ios? What's the difference between this one and index.ios.js then?
There was a problem hiding this comment.
enabled prop is different, that way it only works on ios
|
🚀 Deployed to production in version: 1.0.39-5🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
IOS - Secondary log in - "Done" button is not present to close keyboard #2371 issue
Issue is solved for ios, all other platforms are not affected by this change.
Fixed Issues
Fixes #2371Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android