[No QA] Use env and do not set SHOULD_DEPLOY_PRODUCTION #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In draft until https://github.com/Expensify/Expensify.cash/actions/runs/752698665 finishes, if there are any bugs I will fix them here too. |
|
Merging to hopefully fix deploy process for today's deploy |
|
@roryabraham looks like this was merged without passing tests. Please add a note explaining why this was done or remove the |
66 tasks
|
🚀 [Deployed](https://github.com/Expensify/Expensify.cash
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We were always deploying production and staging (when we only want to deploy one at a time) because of a little bug. This PR will fix that and only deploy one environment at a time.
Fixed Issues
Fixes #2409
Tests
staging-expensify-cash