Code

Edit Comments#2320

Code

Merged

yuwenmemon merged 35 commits intomainExpensify/App:mainfrom yuwen-editCommentsExpensify/App:yuwen-editCommentsCopy head branch name to clipboardMay 11, 2021

+440-35

Commits

Commits on Mar 22, 2021

• Edit Comments - fundamental API portions, version allows to edit to a hardcoded comment in code

  yuwenmemon

  committed
  b318a69

  Copy full SHA for b318a69

Commits on Mar 23, 2021

• Get dirty editing UI in place

  yuwenmemon

  committed
  41e885d

  Copy full SHA for 41e885d

Commits on Apr 9, 2021

• Fix conflicts?

  yuwenmemon

  committed
  8f1fb48

  Copy full SHA for 8f1fb48

• reall fix conflicts

  yuwenmemon

  committed
  94053ea

  Copy full SHA for 94053ea

• Really non-performant comment editing

  yuwenmemon

  committed
  bf1e59c

  Copy full SHA for bf1e59c

Commits on Apr 13, 2021

• Make sure we have reportID in grouped report action item

  yuwenmemon

  committed
  8500513

  Copy full SHA for 8500513

Commits on Apr 14, 2021

• Fix the stylings for a message being edited

  yuwenmemon

  committed
  8f8fd1c

  Copy full SHA for 8f8fd1c

• Make it so that clicking the edit comment button again cancels the edit

  yuwenmemon

  committed
  00fae5d

  Copy full SHA for 00fae5d

• Add keypress handlers

  yuwenmemon

  committed
  e967c38

  Copy full SHA for e967c38

• Fix conflicts

  yuwenmemon

  committed
  f94a9c4

  Copy full SHA for f94a9c4

• Revert some unneccessary measureContent crap I edited out

  yuwenmemon

  committed
  cc295ae

  Copy full SHA for cc295ae

• Fix a couple bugs

  yuwenmemon

  committed
  235cf83

  Copy full SHA for 235cf83

Commits on Apr 15, 2021

• Add edited indicator

  yuwenmemon

  committed
  40c7c30

  Copy full SHA for 40c7c30

Commits on Apr 23, 2021

• Add some comments, get this in more a polished state, PR comments

  yuwenmemon

  committed
  ca5d13e

  Copy full SHA for ca5d13e

• Fix conflicts

  yuwenmemon

  committed
  32103ae

  Copy full SHA for 32103ae

Commits on Apr 28, 2021

• hidePopover

  yuwenmemon

  committed
  5d0536f

  Copy full SHA for 5d0536f

• Fix conflicts

  yuwenmemon

  committed
  2594d4f

  Copy full SHA for 2594d4f

• Playing around with ReportScrollManager

  yuwenmemon

  committed
  ce406cd

  Copy full SHA for ce406cd

Commits on Apr 30, 2021

• Scroll touch screens to comment when editing a comment

  yuwenmemon

  committed
  a29f272

  Copy full SHA for a29f272

• Show/hide compose box when focusing on editing comment in mobile

  yuwenmemon

  committed
  da33bc6

  Copy full SHA for da33bc6

• Linting

  yuwenmemon

  committed
  1ef1bce

  Copy full SHA for 1ef1bce

Commits on May 4, 2021

• PR Comments

  yuwenmemon

  committed
  ffe69f1

  Copy full SHA for ffe69f1

• Remove uneccessary blur event

  yuwenmemon

  committed
  1aca583

  Copy full SHA for 1aca583

Commits on May 5, 2021

• Fix Conflicts

  yuwenmemon

  committed
  e1185d2

  Copy full SHA for e1185d2

Commits on May 6, 2021

• Update when recieving an edited message via pusher event

  yuwenmemon

  committed
  4fd791d

  Copy full SHA for 4fd791d

• Hide report compose when editing comment on all small screens

  yuwenmemon

  committed
  243819e

  Copy full SHA for 243819e

• Line length

  yuwenmemon

  committed
  4809f11

  Copy full SHA for 4809f11

Commits on May 10, 2021

• Fix conflicts

  yuwenmemon

  committed
  12ce6e8

  Copy full SHA for 12ce6e8

• Add doc for scrollToIndex

  yuwenmemon

  committed
  a2259c2

  Copy full SHA for a2259c2

• Fix conflictrs

  yuwenmemon

  committed
  932565a

  Copy full SHA for 932565a

• Dumb auto styling fix

  yuwenmemon

  committed
  dfae939

  Copy full SHA for dfae939

• PR Comments

  yuwenmemon

  committed
  e7abc09

  Copy full SHA for e7abc09

• Make sure we have a reportActionID if we're going to allow you to edit a comment

  yuwenmemon

  committed
  f4156d0

  Copy full SHA for f4156d0

• Resolve console error when textInput has no focus method

  yuwenmemon

  committed
  89f7537

  Copy full SHA for 89f7537

Commits on May 11, 2021

• Keyboard persists taps handled

  yuwenmemon

  committed
  8011820

  Copy full SHA for 8011820