Fix: for mWeb(ios safari) float button up for the screen when keyboard opens for the form input #23185

Pujan92 · 2023-07-19T18:18:43Z

Details

Added shouldEnableMaxHeight prop to the ScreenWrapper component to float the Next/Save button up to get rid of extra empty space when keyboard gets opened(mWeb - ios safari).

Fixed Issues

$ #22661
PROPOSAL: #22661 (comment)

Tests

For mWeb(safari), Verify the form submit button floats up for the below screens when the keyboard gets opened for any form input

Task Flow

New task details page(Click Fab icon -> Assign Task)
New task title page(Click Fab icon -> Assign Task -> Fill details and next -> Select Title)
New task description page(Click Fab icon -> Assign Task -> Fill details and next -> Select Description)
Task Report title page(Open any task report -> Select Title)
Task Report description page(Open any task report -> Select Description)

Workspace Flow

Workspace settings page(Goto Settings -> Workspaces -> Select any workspace -> Settings)

Profile Flow

Display name page(Goto Settings -> Profile -> Display Name)
New contact method page(Goto Settings -> Profile -> Contact methods -> New contact method)
Legal name page(Goto Settings -> Profile -> Personal Details -> Legal name)

Verify that no errors appear in the JS console

Offline tests

For mWeb(safari), Verify the form submit button floats up for the below screens when the keyboard gets opened for any form input

Task Flow

New task details page(Click Fab icon -> Assign Task)
New task title page(Click Fab icon -> Assign Task -> Fill details and next -> Select Title)
New task description page(Click Fab icon -> Assign Task -> Fill details and next -> Select Description)
Task Report title page(Open any task report -> Select Title)
Task Report description page(Open any task report -> Select Description)

Workspace Flow

Workspace settings page(Goto Settings -> Workspaces -> Select any workspace -> Settings)

Profile Flow

Display name page(Goto Settings -> Profile -> Display Name)
New contact method page(Goto Settings -> Profile -> Contact methods -> New contact method)
Legal name page(Goto Settings -> Profile -> Personal Details -> Legal name)

QA Steps

For mWeb(safari), Verify the form submit button floats up for the below screens when the keyboard gets opened for any form input

Task Flow

New task details page(Click Fab icon -> Assign Task)
New task title page(Click Fab icon -> Assign Task -> Fill details and next -> Select Title)
New task description page(Click Fab icon -> Assign Task -> Fill details and next -> Select Description)
Task Report title page(Open any task report -> Select Title)
Task Report description page(Open any task report -> Select Description)

Workspace Flow

Workspace settings page(Goto Settings -> Workspaces -> Select any workspace -> Settings)

Profile Flow

Display name page(Goto Settings -> Profile -> Display Name)
New contact method page(Goto Settings -> Profile -> Contact methods -> New contact method)
Legal name page(Goto Settings -> Profile -> Personal Details -> Legal name)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

https://drive.google.com/file/d/1L4-_BHX9MHVxQhNnRApLDMFoB5pzGNpk/view?usp=sharing

Desktop

iOS

Android

melvin-bot · 2023-07-19T18:18:51Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt · 2023-07-20T08:26:34Z

Home Address: Button is not visible

Close account page: Extra empty space

Pujan92 · 2023-07-20T10:15:29Z

@s77rt It is not a fixed footer so it will stay at the bottom after a form. Only the gap between the form and the button gets reduced with the maxHeight change which is convenient to the user for seeing the button on scroll after form.

s77rt · 2023-07-20T11:58:36Z

@Pujan92 On the home address page I can't find the button at all, even scrolling down, it just vanished 😅. On the close account page, that seems like a regression, I think we had an issue reported for that before, you can also see the header is not visible either.

Pujan92 · 2023-07-20T13:03:57Z

@s77rt Seems for scrolling content when we open keyboard for bottom inputs, somehow the View is not assigning correct maxHeight. Not sure yet about exactly what causes this issue.

Simulator.Screen.Recording.-.iPhone.14.-.2023-07-20.at.18.32.30.mp4

Pujan92 · 2023-07-20T13:21:41Z

I think this is related to #8731 and as per the comment known bug to the ios safari.
In that case @s77rt , I can revert the change for these scrolling components (Home Address, Close account)

s77rt · 2023-07-20T15:44:09Z

@Pujan92 Yes, let's revert those pages

Pujan92 · 2023-07-20T16:47:02Z

@Pujan92 Yes, let's revert those pages

Reverted.

s77rt · 2023-07-20T18:05:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

s77rt

LGTM! 🚀

OSBotify · 2023-07-21T08:32:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-21T18:50:12Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-25T01:24:09Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.44-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-25T01:44:30Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.45-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-26T15:54:01Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.45-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

added shouldEnableMaxHeight to ScreenWrapper for ios safari

a32fa95

Pujan92 requested a review from a team as a code owner July 19, 2023 18:18

melvin-bot bot requested review from s77rt and removed request for a team July 19, 2023 18:18

Pujan92 mentioned this pull request Jul 19, 2023

[HOLD for payment 2023-08-01] [$1000] mWeb - Next button is hidden behind the keyboard #22661

Closed

6 tasks

reverted shouldEnableMaxHeight for closeAccount and Address page

7a125af

s77rt approved these changes Jul 20, 2023

View reviewed changes

melvin-bot bot requested a review from Beamanator July 20, 2023 18:06

Beamanator approved these changes Jul 21, 2023

View reviewed changes

Beamanator merged commit a97ca9b into Expensify:main Jul 21, 2023

OSBotify mentioned this pull request Jul 21, 2023

Deploy Checklist: New Expensify 2023-07-21 #23362

Closed

OSBotify mentioned this pull request Jul 25, 2023

Deploy Checklist: New Expensify 2023-07-25 #23522

Closed

jjcoffee mentioned this pull request Aug 26, 2024

[HOLD for payment 2024-08-29] [$250] mWeb/Safari - Keypad overlap composer & blank space in header when open admins room from WS share pg #47063

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: for mWeb(ios safari) float button up for the screen when keyboard opens for the form input #23185

Fix: for mWeb(ios safari) float button up for the screen when keyboard opens for the form input #23185

Pujan92 commented Jul 19, 2023 •

edited

Loading

melvin-bot bot commented Jul 19, 2023

s77rt commented Jul 20, 2023

Pujan92 commented Jul 20, 2023

s77rt commented Jul 20, 2023

Pujan92 commented Jul 20, 2023 •

edited

Loading

Pujan92 commented Jul 20, 2023 •

edited

Loading

s77rt commented Jul 20, 2023

Pujan92 commented Jul 20, 2023

s77rt commented Jul 20, 2023

s77rt left a comment

OSBotify commented Jul 21, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 26, 2023

Fix: for mWeb(ios safari) float button up for the screen when keyboard opens for the form input #23185

Fix: for mWeb(ios safari) float button up for the screen when keyboard opens for the form input #23185

Conversation

Pujan92 commented Jul 19, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 19, 2023

s77rt commented Jul 20, 2023

Pujan92 commented Jul 20, 2023

s77rt commented Jul 20, 2023

Pujan92 commented Jul 20, 2023 • edited Loading

Pujan92 commented Jul 20, 2023 • edited Loading

s77rt commented Jul 20, 2023

Pujan92 commented Jul 20, 2023

s77rt commented Jul 20, 2023

Reviewer Checklist

Screenshots/Videos

s77rt left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 21, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 26, 2023

Pujan92 commented Jul 19, 2023 •

edited

Loading

Pujan92 commented Jul 20, 2023 •

edited

Loading

Pujan92 commented Jul 20, 2023 •

edited

Loading