Fix the modal dismiss behavior #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pecanoro
reviewed
Apr 9, 2021
| */ | ||
| function dismissModal() { | ||
| function dismissModal(shouldOpenDrawer = false) { |
There was a problem hiding this comment.
NAB, just learning, what is the drawer?
There was a problem hiding this comment.
The main app (anything not a modal) is split into two panels in a DrawerNavigator. The left part of the drawer is the "drawer content" and set to the LHN/Sidebar and the right side is the report/chat screen. On larger screens, the drawer is permanently expanded, but on smaller screens / mobile it can be toggled back and forth programmatically or by swiping.
pecanoro
approved these changes
Apr 9, 2021
|
Travis failed! |
|
Merging master now to see if it fixes. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Adds the ability to dismiss modals back to either the LHN or the last screen they were triggered from (so just the Report screen at the moment).
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/157574
Tests
QA Steps
xin the top right corner to dismiss the modalxin the top right corner to dismiss the modalxin the top right corner to dismiss the modalTested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android