Inconsistent Android back button behavior while navigated to a modal view #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works perfectly fine for me. @ahmedahtazaz can you please add test and QA steps here? |
|
Testing steps added. |
|
@marcaaron i have tested it on Android 6 real device and Android 11 emulator. Which Android versions have you tested on? |
thienlnam
approved these changes
Apr 9, 2021
There was a problem hiding this comment.
Approving since the package install worked fine for me and the tests worked on my device, handing it to you @marcaaron
|
Cool. Let's see how this goes. Worst case scenario we will look into upgrading the other dependencies if there are any issues. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Yeah okay cool. Let's hope for the best |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marcaaron Version upgrade of @react-navigation/drawer to 5.12.5
Details
Version upgrade of @react-navigation/drawer to 5.12.5
Fixed Issues
Fixes #2066
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android