Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Add Attachment" Menu Item #2254

Merged

Conversation

Maftalion
Copy link
Contributor

Details

Fixed Issues

Fixes #2053

Tests

  • Go into any chat and click the + icon

QA Steps

  • same as above

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-04-06 at 6 05 23 PM

Mobile Web

Screen Shot 2021-04-06 at 6 24 22 PM

Desktop

Screen Shot 2021-04-06 at 6 15 13 PM

iOS

Screen Shot 2021-04-06 at 6 22 07 PM

Android

Screen Shot 2021-04-06 at 6 17 01 PM

@Maftalion Maftalion requested a review from a team as a code owner April 7, 2021 01:25
@MelvinBot MelvinBot requested review from tylerkaraszewski and removed request for a team April 7, 2021 01:25
@trjExpensify trjExpensify self-requested a review April 14, 2021 18:34
@trjExpensify
Copy link
Contributor

Simple copy change, grabbing this from @tylerkaraszewski to get it over the line.

@trjExpensify trjExpensify merged commit 29fe119 into Expensify:master Apr 14, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 [Deployed](https://github.com/Expensify/Expensify.cash
/actions/runs/765130740) 🚀 to
staging on Mon Apr 19 2021 at 22:41:56 GMT+0000 (Coordinated Universal Time)

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[User Settings] Allow users to modify avatar photo
3 participants