Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for Room Name to accept Spanish Alphabet #22345

Merged
merged 7 commits into from
Jul 12, 2023
Merged

Add validation for Room Name to accept Spanish Alphabet #22345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a79cca5
fix: Add validation for Room Name to accept Spanish Alphabets
jayeshmangwani Jul 4, 2023
7ea6641
Merge branch 'main' into add_validation_room_name_spanish_alphabets
jayeshmangwani Jul 5, 2023
5df7039
Merge branch 'main' into add_validation_room_name_spanish_alphabets
jayeshmangwani Jul 5, 2023
2d9a3ac
Merge branch 'main' into add_validation_room_name_spanish_alphabets
jayeshmangwani Jul 6, 2023
f62aeb5
Merge branch 'main' into add_validation_room_name_spanish_alphabets
jayeshmangwani Jul 6, 2023
e93c873
Merge branch 'main' into add_validation_room_name_spanish_alphabets
jayeshmangwani Jul 7, 2023
e0c5a6e
Merge branch 'main' into add_validation_room_name_spanish_alphabets
jayeshmangwani Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CONST.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1134,7 +1134,7 @@ const CONST = {
CARD_SECURITY_CODE: /^[0-9]{3,4}$/,
CARD_EXPIRATION_DATE: /^(0[1-9]|1[0-2])([^0-9])?([0-9]{4}|([0-9]{2}))$/,
PAYPAL_ME_USERNAME: /^[a-zA-Z0-9]{1,20}$/,
ROOM_NAME: /^#[a-z0-9-]{1,80}$/,
ROOM_NAME: /^#[a-z0-9à-ÿ-]{1,80}$/,

// eslint-disable-next-line max-len, no-misleading-character-class
EMOJIS: /[\p{Extended_Pictographic}\u200d\u{1f1e6}-\u{1f1ff}\u{1f3fb}-\u{1f3ff}\u{e0020}-\u{e007f}\u20E3\uFE0F]|[#*0-9]\uFE0F?\u20E3/gu,
Expand Down
4 changes: 4 additions & 0 deletions tests/unit/ValidationUtilsTest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ describe('ValidationUtils', () => {
test('room name with lowercase letters, numbers, and dashes', () => {
expect(ValidationUtils.isValidRoomName('#this-is-a-room1')).toBe(true);
});

test('room name with spanish Accented letters and dashes', () => {
expect(ValidationUtils.isValidRoomName('#sala-de-opinión')).toBe(true);
});
});

describe('isValidWebsite', () => {
Expand Down