-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flavor support #21551
Merged
Merged
Flavor support #21551
Changes from 26 commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
7bcbb8b
add flavors
staszekscp b84fefe
support flavors on android
staszekscp c2189e4
fix name
staszekscp 991ed02
improve android splashscreen
staszekscp f9f7a9a
fix android script in package.json
staszekscp 6e6c1ff
fix last lines
staszekscp 6274443
fix fastfile
staszekscp fc4f72a
Merge branch 'main' into flavor-support
staszekscp 4c4ae64
add basic scheme support for ios
staszekscp d5e9a41
add icon to schemes
staszekscp a2bd8a0
fix package.json
staszekscp 70545fe
add .env detection
staszekscp 2d23f8a
Merge branch 'main' into flavor-support
staszekscp 3aa64ff
Merge branch 'main' into flavor-support
staszekscp 13f8dd5
merge
staszekscp e0449f9
Merge branch 'main' into flavor-support
mczernek f4f3113
Remove unnecesary buildTypes and flavors, add e2e flavor.
mczernek 71dbe1e
Remove Staging from iOS.
mczernek 3e3b345
Remove staging from some leftovers.
mczernek e353839
Fix Fastlane according to new flavors/buildTypes configuration.
mczernek aa383d6
Merge remote-tracking branch 'expensify/main' into flavor-support
kowczarz 047adac
Add icons based on flavour to splash screen
kowczarz 097adf4
Disable unused android build variants
kowczarz ca982f1
Fix splash screen icon based on app flavour
kowczarz 26470c2
Merge remote-tracking branch 'expensify/main' into flavor-support
kowczarz 4c0b60f
Update env configuration
kowczarz ca85783
Update env configuration for e2e flavor
kowczarz dfa2d9c
Typo
kowczarz 6cea881
Remove unused assets
kowczarz 2c5174a
Fix lint issues
kowczarz df78bfb
Fix build gradle
kowczarz 8397672
Fix podfile issues
kowczarz e85a760
Move bootsplash files to specific directories
kowczarz 8b77667
Merge remote-tracking branch 'expensify/main' into flavor-support
kowczarz defc4b9
Add xcode selection for iOS fastlane
kowczarz 768c27d
Fix filename typo
kowczarz 30a30a1
Merge remote-tracking branch 'expensify/main' into flavor-support
kowczarz 7df7319
Change signing config for non-production flavors on android
kowczarz 84d015c
Force latest xcode version in GitHub Action
kowczarz 0cba771
Bump up xcode
kowczarz c0e604e
Merge remote-tracking branch 'expensify/main' into flavor-support
kowczarz d43e1ed
Update Fastfile for ad-hoc provisioning
kowczarz 746ac8a
Merge remote-tracking branch 'expensify/main' into flavor-support
kowczarz fd8e2a6
Updated podfile lock
kowczarz 23ba779
Merge remote-tracking branch 'expensify/main' into flavor-support
kowczarz b4e0aef
Fix pbxproj issues
kowczarz 04406ea
Fix dev and adhoc icon sets
kowczarz 3b0d03e
Merge remote-tracking branch 'expensify/main' into flavor-support
kowczarz 5e19ef7
Add flavor indication on AboutPage.js
kowczarz b4dd6fe
Fix android icons
kowczarz 93fbc24
Fix android round icons
kowczarz c873052
Merge remote-tracking branch 'expensify/main' into flavor-support
kowczarz 2b6f665
Update bundle id and provisioning profile for dev builds
kowczarz ae49ac2
Add app id suffix for android e2e build
kowczarz 282105f
Fix production logo flashing
kowczarz aee92d4
Revert different splash screens on Android
kowczarz 8035662
Revert "Remove unused assets"
kowczarz 24724fe
Fix lint issue
kowczarz 291ec29
Remove unused file
kowczarz 667b9b1
Merge remote-tracking branch 'expensify/main' into flavor-support
kowczarz 9b9ae17
Fix pods
kowczarz b1a8f74
Small nits in build.gradle
kowczarz d6ccac1
Fix logo issue
kowczarz 69923ac
Update missing setup in build.gradle
kowczarz ffc1db5
Typo
kowczarz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,47 +1,143 @@ | ||
{ | ||
"project_info": { | ||
"project_number": "921154746561", | ||
"firebase_url": "https://expensify-chat.firebaseio.com", | ||
"project_id": "expensify-chat", | ||
"storage_bucket": "expensify-chat.appspot.com" | ||
"project_number": "921154746561", | ||
"firebase_url": "https://expensify-chat.firebaseio.com", | ||
"project_id": "expensify-chat", | ||
"storage_bucket": "expensify-chat.appspot.com" | ||
}, | ||
"client": [ | ||
{ | ||
"client_info": { | ||
"mobilesdk_app_id": "1:921154746561:android:4f04268f25f84eaf027c40", | ||
"android_client_info": { | ||
"package_name": "com.expensify.chat" | ||
} | ||
}, | ||
"oauth_client": [ | ||
{ | ||
"client_id": "921154746561-gpsoaqgqfuqrfsjdf8l7vohfkfj7b9up.apps.googleusercontent.com", | ||
"client_type": 3 | ||
} | ||
], | ||
"api_key": [ | ||
{ | ||
"current_key": "AIzaSyCVwQb9lBI06bDIwHOw10AkdJyquXoMngk" | ||
{ | ||
"client_info": { | ||
"mobilesdk_app_id": "1:921154746561:android:4f04268f25f84eaf027c40", | ||
"android_client_info": { | ||
"package_name": "com.expensify.chat" | ||
} | ||
}, | ||
"oauth_client": [ | ||
{ | ||
"client_id": "921154746561-o0pgqgc84e3e97s9iljlmimcb5nesqad.apps.googleusercontent.com", | ||
"client_type": 1, | ||
"android_info": { | ||
"package_name": "com.expensify.chat", | ||
"certificate_hash": "5e8f16062ea3cd2c4a0d547876baa6f38cabf625" | ||
} | ||
}, | ||
{ | ||
"client_id": "921154746561-gpsoaqgqfuqrfsjdf8l7vohfkfj7b9up.apps.googleusercontent.com", | ||
"client_type": 3 | ||
} | ||
], | ||
"api_key": [ | ||
{ | ||
"current_key": "AIzaSyCVwQb9lBI06bDIwHOw10AkdJyquXoMngk" | ||
} | ||
], | ||
"services": { | ||
"appinvite_service": { | ||
"other_platform_oauth_client": [ | ||
{ | ||
"client_id": "921154746561-gpsoaqgqfuqrfsjdf8l7vohfkfj7b9up.apps.googleusercontent.com", | ||
"client_type": 3 | ||
}, | ||
{ | ||
"client_id": "921154746561-080fav7kvk6s70k6nd70mt50isubgff4.apps.googleusercontent.com", | ||
"client_type": 2, | ||
"ios_info": { | ||
"bundle_id": "com.expensify.chat.adhoc" | ||
} | ||
], | ||
"services": { | ||
"appinvite_service": { | ||
"other_platform_oauth_client": [ | ||
{ | ||
"client_id": "921154746561-gpsoaqgqfuqrfsjdf8l7vohfkfj7b9up.apps.googleusercontent.com", | ||
"client_type": 3 | ||
}, | ||
{ | ||
"client_id": "921154746561-s3uqn2oe4m85tufi6mqflbfbuajrm2i3.apps.googleusercontent.com", | ||
"client_type": 2, | ||
"ios_info": { | ||
"bundle_id": "com.chat.expensify.chat" | ||
} | ||
} | ||
] | ||
} | ||
] | ||
} | ||
} | ||
}, | ||
{ | ||
"client_info": { | ||
"mobilesdk_app_id": "1:921154746561:android:333e293a7fef83a8027c40", | ||
"android_client_info": { | ||
"package_name": "com.expensify.chat.adhoc" | ||
} | ||
}, | ||
"oauth_client": [ | ||
{ | ||
"client_id": "921154746561-cbegir0tnc2gan6k1gre5vtn75p60hom.apps.googleusercontent.com", | ||
"client_type": 1, | ||
"android_info": { | ||
"package_name": "com.expensify.chat.adhoc", | ||
"certificate_hash": "5e8f16062ea3cd2c4a0d547876baa6f38cabf625" | ||
} | ||
}, | ||
{ | ||
"client_id": "921154746561-gpsoaqgqfuqrfsjdf8l7vohfkfj7b9up.apps.googleusercontent.com", | ||
"client_type": 3 | ||
} | ||
], | ||
"api_key": [ | ||
{ | ||
"current_key": "AIzaSyCVwQb9lBI06bDIwHOw10AkdJyquXoMngk" | ||
} | ||
], | ||
"services": { | ||
"appinvite_service": { | ||
"other_platform_oauth_client": [ | ||
{ | ||
"client_id": "921154746561-gpsoaqgqfuqrfsjdf8l7vohfkfj7b9up.apps.googleusercontent.com", | ||
"client_type": 3 | ||
}, | ||
{ | ||
"client_id": "921154746561-080fav7kvk6s70k6nd70mt50isubgff4.apps.googleusercontent.com", | ||
"client_type": 2, | ||
"ios_info": { | ||
"bundle_id": "com.expensify.chat.adhoc" | ||
} | ||
} | ||
] | ||
} | ||
} | ||
}, | ||
{ | ||
"client_info": { | ||
"mobilesdk_app_id": "1:921154746561:android:3b19fdbaedb5b586027c40", | ||
"android_client_info": { | ||
"package_name": "com.expensify.chat.dev" | ||
} | ||
}, | ||
"oauth_client": [ | ||
{ | ||
"client_id": "921154746561-svjnccrcn6vet45kn9o7sibb3jemipa6.apps.googleusercontent.com", | ||
"client_type": 1, | ||
"android_info": { | ||
"package_name": "com.expensify.chat.dev", | ||
"certificate_hash": "5e8f16062ea3cd2c4a0d547876baa6f38cabf625" | ||
} | ||
}, | ||
{ | ||
"client_id": "921154746561-gpsoaqgqfuqrfsjdf8l7vohfkfj7b9up.apps.googleusercontent.com", | ||
"client_type": 3 | ||
} | ||
], | ||
"api_key": [ | ||
{ | ||
"current_key": "AIzaSyCVwQb9lBI06bDIwHOw10AkdJyquXoMngk" | ||
} | ||
], | ||
"services": { | ||
"appinvite_service": { | ||
"other_platform_oauth_client": [ | ||
{ | ||
"client_id": "921154746561-gpsoaqgqfuqrfsjdf8l7vohfkfj7b9up.apps.googleusercontent.com", | ||
"client_type": 3 | ||
}, | ||
{ | ||
"client_id": "921154746561-080fav7kvk6s70k6nd70mt50isubgff4.apps.googleusercontent.com", | ||
"client_type": 2, | ||
"ios_info": { | ||
"bundle_id": "com.expensify.chat.adhoc" | ||
} | ||
} | ||
] | ||
} | ||
} | ||
} | ||
], | ||
"configuration_version": "1" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
|
||
<layer-list xmlns:android="http://schemas.android.com/apk/res/android" android:opacity="opaque"> | ||
<item android:gravity="fill"> | ||
<color android:color="?attr/windowSplashScreenBackground" /> | ||
</item> | ||
|
||
<item android:gravity="center" android:drawable="@drawable/ic_bootsplash_adhoc"/> | ||
Julesssss marked this conversation as resolved.
Show resolved
Hide resolved
|
||
</layer-list> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android"> | ||
<background android:drawable="@color/ic_launcher_background"/> | ||
<foreground android:drawable="@mipmap/ic_launcher_foreground"/> | ||
</adaptive-icon> |
5 changes: 5 additions & 0 deletions
5
android/app/src/adhoc/res/mipmap-anydpi-v26/ic_launcher_round.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android"> | ||
<background android:drawable="@color/ic_launcher_background"/> | ||
<foreground android:drawable="@mipmap/ic_launcher_foreground"/> | ||
</adaptive-icon> |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
<resources> | ||
<string name="app_name">New Expensify AdHoc</string> | ||
</resources> |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
|
||
<layer-list xmlns:android="http://schemas.android.com/apk/res/android" android:opacity="opaque"> | ||
<item android:gravity="fill"> | ||
<color android:color="?attr/windowSplashScreenBackground" /> | ||
</item> | ||
|
||
<item android:gravity="center" android:drawable="@drawable/ic_bootsplash_dev"/> | ||
</layer-list> |
5 changes: 5 additions & 0 deletions
5
android/app/src/development/res/mipmap-anydpi-v26/ic_launcher.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android"> | ||
<background android:drawable="@color/ic_launcher_background"/> | ||
<foreground android:drawable="@mipmap/ic_launcher_foreground"/> | ||
</adaptive-icon> |
5 changes: 5 additions & 0 deletions
5
android/app/src/development/res/mipmap-anydpi-v26/ic_launcher_round.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android"> | ||
<background android:drawable="@color/ic_launcher_background"/> | ||
<foreground android:drawable="@mipmap/ic_launcher_foreground"/> | ||
</adaptive-icon> |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+12.6 KB
android/app/src/development/res/mipmap-hdpi/ic_launcher_foreground.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file added
BIN
+6.22 KB
android/app/src/development/res/mipmap-mdpi/ic_launcher_foreground.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file added
BIN
+15.9 KB
android/app/src/development/res/mipmap-xhdpi/ic_launcher_foreground.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file added
BIN
+47.9 KB
android/app/src/development/res/mipmap-xxhdpi/ic_launcher_foreground.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file added
BIN
+71.3 KB
android/app/src/development/res/mipmap-xxxhdpi/ic_launcher_foreground.png
Oops, something went wrong.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
<resources> | ||
<string name="app_name">New Expensify Dev</string> | ||
</resources> |
File renamed without changes.
20 changes: 0 additions & 20 deletions
20
android/app/src/e2eRelease/java/com/expensify/chat/ReactNativeFlipper.java
This file was deleted.
Oops, something went wrong.
7 changes: 0 additions & 7 deletions
7
android/app/src/internalRelease/assets/airshipconfig.properties
This file was deleted.
Oops, something went wrong.
20 changes: 0 additions & 20 deletions
20
android/app/src/internalRelease/java/com/expensify/chat/ReactNativeFlipper.java
This file was deleted.
Oops, something went wrong.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
<vector xmlns:android="http://schemas.android.com/apk/res/android" | ||
android:width="100dp" | ||
android:height="100dp" | ||
android:viewportWidth="100" | ||
android:viewportHeight="100"> | ||
<path | ||
android:pathData="M74,15.63a42.03,42.03 0,0 0,-24 -7.5A41.77,41.77 0,0 0,8.12 49.87c0,9 2.76,17.26 7.5,24a4.35,4.35 0,0 1,-0.37 5.63c-1.75,1.63 -4.5,1.5 -5.88,-0.38A49.99,49.99 0,0 1,50 0c10.88,0.01 20.88,3.51 29.25,9.38 2,1.5 2,4.26 0.38,5.88a4.35,4.35 0,0 1,-5.63 0.38ZM67.62,24.87L67.62,35.5L45.25,35.5v9.13h18v10.62h-18v9.63L67.5,64.88v10.37L32.25,75.25L32.25,24.87h35.38ZM91.12,21.75a3.78,3.78 0,0 0,-5.87 -0.38,4.35 4.35,0 0,0 -0.5,5.5c4.38,6.63 7,14.63 7,23.13 0,8.5 -2.63,16.75 -7.25,23.5 -1.13,1.75 -1.13,4.13 0.38,5.63 1.75,1.75 4.5,1.62 5.87,-0.38A49.5,49.5 0,0 0,99.88 50a47.66,47.66 0,0 0,-8.75 -28.25ZM26.88,84.88c6.63,4.37 14.63,7 23.13,7 8.63,0 16.75,-2.75 23.5,-7.25a4.35,4.35 0,0 1,5.63 0.37c1.75,1.75 1.62,4.5 -0.38,5.88A50.37,50.37 0,0 1,50 100a49.75,49.75 0,0 1,-28.25 -8.75c-2,-1.38 -2.13,-4.13 -0.38,-5.88 1.38,-1.5 3.75,-1.62 5.5,-0.5Z" | ||
android:fillColor="#002E22" | ||
android:fillType="evenOdd"/> | ||
</vector> | ||
kowczarz marked this conversation as resolved.
Show resolved
Hide resolved
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we just leaving this empty object to make it clearer to other devs that it COULD be used? if so can you please just add a small comment inside to explain? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some cleanup here.