[Hold Web-E 30480] Added chronosInCash beta

[deetergp]

PullerBear chooses @thienlnam

Held on https://github.com/Expensify/Web-Expensify/pull/30480. I could probably just pull the beta bits out of that PR, and just commit them on their own.

cc @flodnv @marcaaron

Details

Added a beta to Web and E.cash to prevent non-beta users from being able to chat with Chronos.

Related Issues

• https://github.com/Expensify/Expensify/issues/157087

Tests

1. Fliped the boolean on this line to false.
2. Used Betatify to add the chronosInCash beta to my scott.hasbeta@deetfoo.com
   • Betatify seemed broken locally, so I added the beta here and it worked fine
3. Logged in as scott.hasbeta@deetfoo.com
4. Typed chronos@expensify.com and verified that the user appeared as someone I could start a chat with.
   
5. Logged out
6. Logged in as scott.hasnobeta@deetfoo (stashing the change to line 218)
7. Performed step 4 and verified that I did not have the option to begin a chat with Chronos
   

I performed these same steps on all platforms.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[deetergp]

Removing the request for @MariaHCD to review since this is a WIP that I won't get back to till Monday.

[deetergp]

I have read the CLA Document and I hereby sign the CLA

[deetergp]

In order to test this, I need to apply this diff:

diff --git a/lib/BetaManager.php b/lib/BetaManager.php
index 1395d91b563..6ee283adcd5 100644
--- a/lib/BetaManager.php
+++ b/lib/BetaManager.php
@@ -83,7 +83,7 @@ class BetaManager
      *
      * @var bool
      */
-    private static $allBetasEnabled = true;
+    private static $allBetasEnabled = false;

     /**
      * This property only is used while on DEBUG mode, it indicates if a beta is enabled or not. Mostly for testing.

[marcaaron]

LGTM but had a couple of comments.

Do we also want to avoid having chronos@expensify.com show up as a user in the personalDetails array returned from getOptions()?

[deetergp]

Updated!

[marcaaron]

LGTM

[deetergp]

Updated to resolve some merge conflicts and some master vs. main confusion.

[thienlnam]

This can be merged once the pending PR is on production right?

[deetergp]

I don't think anything bad would happen if we merged this now, but I'm not 100% sure about it, so we might as well play it safe and wait.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging in version: 1.0.31-1🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production in version: 1.0.39-5🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅