-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Update electron-notarize package name #20218
Conversation
|
Reviewer Checklist
Screenshots/VideosWebN/A - GitHub Actions changes Mobile Web - ChromeN/A - GitHub Actions changes Mobile Web - SafariN/A - GitHub Actions changes DesktopN/A - GitHub Actions changes iOSN/A - GitHub Actions changes AndroidN/A - GitHub Actions changes |
[No QA] Update electron-notarize package name (cherry picked from commit 9d492f1)
…-20218 🍒 Cherry pick PR #20218 to staging 🍒
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.24-3 🚀
|
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.24-3 🚀
|
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀
|
Details
#20210 changed the electron-notary package name but we missed this import. I'm surprised this didn't get picked up by eslint...
Fixed Issues
$ n/a – broken deploys
Tests
Must merge to live-test.
Offline tests
n/a
QA Steps
None.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android