Fix: `Add attachments` and `Delete workspace` buttons are not responsive #19339

tienifr · 2023-05-20T12:32:05Z

Details

'Upload photo', 'Add attachment', 'Delete workspace' buttons are not working. This PR fixes that.

Fixed Issues

$ #19310
PROPOSAL: #19310 (comment)

Tests

Login with any account
Go to Settings > Workspaces > Any workspace > General settings
Tap on workspace avatar >> Upload photo
Verify that the directory popup shows to select photo
Click on '3 dots' button >> Delete workspace
Verify that the workspace is deleted successfully
Go to any chat
Tap [ + ] on composer >> Add attachments
Verify that the directory popup shows to select attachment

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login with any account
Go to Settings > Workspaces > Any workspace > General settings
Tap on workspace avatar >> Upload photo
Verify that the directory popup shows to select photo
Click on '3 dots' button >> Delete workspace
Verify that the workspace is deleted successfully
Go to any chat
Tap [ + ] on composer >> Add attachments
Verify that the directory popup shows to select attachment

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screencast.from.20-05-2023.19.58.13.webm

Mobile Web - Chrome

video_2023-05-20_20-09-05.mp4

Mobile Web - Safari

screen-recording-2023-05-20-at-202343_q289aZ0n.mp4

Desktop

screen-recording-2023-05-20-at-202825_c26NdYS5.mp4

iOS

screen-recording-2023-05-20-at-204758_cr16NaGp.mp4

Android

untitled_k7wi0Yax.mp4

melvin-bot · 2023-05-20T13:51:05Z

@cead22 @fedirjh One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2023-05-20T18:57:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-21.at.00.41.20.mov

Mobile Web - Chrome

Screen.Recording.2023-05-21.at.00.43.07.mov

Mobile Web - Safari

Screen.Recording.2023-05-21.at.00.54.23.mov

Desktop

Screen.Recording.2023-05-21.at.00.56.44.mov

iOS

Screen.Recording.2023-05-21.at.01.00.45.mov

Android

WhatsApp.Video.2023-05-21.at.01.05.44.mp4

github-actions · 2023-05-20T18:58:08Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

rushatgabhane

@puneetlath LGTM!

…nt-not-responsive-ios Fix: `Add attachments` and `Delete workspace` buttons are not responsive (cherry picked from commit f4883cd)

…-19339 🍒 Cherry pick PR #19339 to staging 🍒

OSBotify · 2023-05-20T20:46:36Z

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 1.3.16-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-05-22T23:39:18Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.16-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-05-23T00:15:13Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.16-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-05-23T19:53:07Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.16-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-05-23T21:51:51Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.16-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-15T01:27:57Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:45:45Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jjcoffee · 2023-09-18T12:11:51Z

I believe this PR caused this issue #26228 where the FAB didn't always open the correct page in the RHP when navigating by keyboard, since selectedItemIndex wasn't updated when onModalHide was called.

fix: buttons attachment not responsive ios

60bfb61

tienifr changed the title ~~fix: buttons attachment not responsive ios~~ Fix: buttons attachment not responsive May 20, 2023

tienifr changed the title ~~Fix: buttons attachment not responsive~~ Fix: Buttons attachment not responsive May 20, 2023

tienifr changed the title ~~Fix: Buttons attachment not responsive~~ Fix: Add attachment and Delete workspace buttons are not responsive May 20, 2023

tienifr changed the title ~~Fix: Add attachment and Delete workspace buttons are not responsive~~ Fix: Add attachments and Delete workspace buttons are not responsive May 20, 2023

tienifr marked this pull request as ready for review May 20, 2023 13:51

tienifr requested a review from a team as a code owner May 20, 2023 13:51

melvin-bot bot requested review from cead22 and fedirjh and removed request for a team May 20, 2023 13:51

puneetlath added the CP Staging label May 20, 2023

rushatgabhane approved these changes May 20, 2023

View reviewed changes

puneetlath approved these changes May 20, 2023

View reviewed changes

puneetlath merged commit f4883cd into Expensify:main May 20, 2023

OSBotify mentioned this pull request May 20, 2023

🍒 Cherry pick PR #19339 to staging 🍒 #19354

Merged

OSBotify pushed a commit that referenced this pull request May 20, 2023

Merge pull request #19339 from tienifr/fix/19310-buttons-add-attachme…

1751961

…nt-not-responsive-ios Fix: `Add attachments` and `Delete workspace` buttons are not responsive (cherry picked from commit f4883cd)

OSBotify added a commit that referenced this pull request May 20, 2023

Merge pull request #19354 from Expensify/OSBotify-cherry-pick-staging…

a4834ad

…-19339 🍒 Cherry pick PR #19339 to staging 🍒

OSBotify mentioned this pull request May 20, 2023

Deploy Checklist: New Expensify 2023-05-18 #19175

Closed

39 tasks

melvin-bot bot mentioned this pull request May 22, 2023

[HOLD for payment 2023-05-29] [$1000] iOS/iPad - Buttons to add attachments, delete workspace, and upload an avatar are unrepsonsive #19310

Closed

6 tasks

OSBotify mentioned this pull request May 23, 2023

Deploy Checklist: New Expensify 2023-05-22 #19422

Closed

62 tasks

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

alex2bc mentioned this pull request Aug 9, 2023

[$1000] Remove Safari workaround to fix attachment picker issue #24297

Closed

jjcoffee mentioned this pull request Sep 18, 2023

[HOLD for payment 2023-09-20] [$1000] FAB menu - Pressing Enter doesn't open the selected option page #26228

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: `Add attachments` and `Delete workspace` buttons are not responsive #19339

Fix: `Add attachments` and `Delete workspace` buttons are not responsive #19339

tienifr commented May 20, 2023 •

edited

Loading

melvin-bot bot commented May 20, 2023

rushatgabhane commented May 20, 2023 •

edited

Loading

github-actions bot commented May 20, 2023

rushatgabhane left a comment

OSBotify commented May 20, 2023

OSBotify commented May 22, 2023

OSBotify commented May 23, 2023

OSBotify commented May 23, 2023

OSBotify commented May 23, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

jjcoffee commented Sep 18, 2023

Fix: Add attachments and Delete workspace buttons are not responsive #19339

Fix: Add attachments and Delete workspace buttons are not responsive #19339

Conversation

tienifr commented May 20, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 20, 2023

rushatgabhane commented May 20, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

github-actions bot commented May 20, 2023

rushatgabhane left a comment

Choose a reason for hiding this comment

OSBotify commented May 20, 2023

OSBotify commented May 22, 2023

OSBotify commented May 23, 2023

OSBotify commented May 23, 2023

OSBotify commented May 23, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

jjcoffee commented Sep 18, 2023

Fix: `Add attachments` and `Delete workspace` buttons are not responsive #19339

Fix: `Add attachments` and `Delete workspace` buttons are not responsive #19339

tienifr commented May 20, 2023 •

edited

Loading

rushatgabhane commented May 20, 2023 •

edited

Loading