Fix User can not validate an account in Desktop app #19125

hoangzinh · 2023-05-17T16:39:33Z

Details

Fixed Issues

$ #17724
PROPOSAL: #17724 (comment)

Tests

Access the Expensify Desktop app
Sign in with an email that does not exist
Click on Expensify's magic link from mailbox
Verify that the magic link opened in Web with a redirect loading page
Click open Desktop app in Alert
Verify that user can sign in normally in Desktop app
Sign out current user in Desktop app
Repeat 1->4
Cancel Alert
Click link "open this link in your browser"
Verify that user can see the magic link code

Verify that no errors appear in the JS console

Offline tests

This feature can't test when offline

QA Steps

Same as Test

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-18.at.00.13.06.-.web.mp4

Mobile Web - Chrome

N/A

Mobile Web - Safari

N/A

Desktop

N/A

iOS

N/A

Android

N/A

hoangzinh · 2023-05-17T16:41:16Z

src/components/DeeplinkWrapper/DeeplinkRedirectLoadingIndicator.js

+};
+
+const DeeplinkRedirectLoadingIndicator = (props) => (
+    <View style={styles.deeplinkWrapperContainer}>


Copied from previous redirect indicator https://github.com/Expensify/App/pull/16383/files#diff-ccbc9d5854dd4a9fa4e90ff053092cf02d44d109a75426d36b8ea72afd3613feL123-L156

hoangzinh · 2023-05-17T16:41:49Z

src/components/DeeplinkWrapper/index.website.js

+    }
+
+    deeplinkNeedRedirectLoadingIndicator() {
+        const validateLoginUrlPattern = '/v($|(//*))';


Copied from previous deeplink pattern 8b9ad23#diff-4a06a628c4f2fa783e590af0b888f09723c061691252843b9e5270df3ae95d45L23-L24

/v($|(//*))

@hoangzinh this can be move to CONST file -> REGEX

I updated PR for above suggestion

melvin-bot · 2023-05-17T17:22:37Z

@bondydaa @rushatgabhane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2023-05-18T22:33:24Z

Quick bump for code review

bondydaa · 2023-05-18T22:37:06Z

yep testing it now. getting some errors that are preventing me from logging in at all and not sure if it's something from the PR or changes to the backend 😬

This is what I get after I use the validation link, I don't get any errors in my logs and the SigninUserWithLink request shows it's returning an authToken properly.

it seems to redirect me to the /r and that's what is causing the oops. still investigating

bondydaa · 2023-05-18T22:57:59Z

Hmm I might have selected the "never ask again" option in chrome that is used to open in the app which might have been the cause of the errors I was seeing. I reset cookies and site data which I think helped as now I'm seeing a loading spinner and not a oops:

but I still didn't get the prompt to open in app

bondydaa · 2023-05-18T23:04:48Z

hmm yeah I cannot figure this out 😬

here are the errors I'm seeing in my console

I saw this one Failed prop type: Invalid prop reportActionsof typeobjectsupplied toReportScreen, expected an array while on main as well so I don't think it's related here.

hoangzinh · 2023-05-18T23:34:00Z

Interesting. Do you mind to go to clear Onyx data in your browser? @bondydaa I still don't know why all of your error related to index.desktop.js, which is weird because we're in web.

rushatgabhane

@hoangzinh minor style comments that need to be addressed

rushatgabhane · 2023-05-19T17:52:33Z

src/components/DeeplinkWrapper/index.website.js

@@ -37,8 +38,10 @@ class DeeplinkWrapper extends PureComponent {
        this.state = {
            appInstallationCheckStatus:
                this.isMacOSWeb() && CONFIG.ENVIRONMENT !== CONST.ENVIRONMENT.DEV ? CONST.DESKTOP_DEEPLINK_APP_STATE.CHECKING : CONST.DESKTOP_DEEPLINK_APP_STATE.NOT_INSTALLED,
+            isOpenLinkInBrowser: false,


NAB: rename to shouldOpenLinkInBrowser

I updated PR for above suggestion. Thank you

rushatgabhane · 2023-05-19T17:56:35Z

src/components/DeeplinkWrapper/index.website.js

+        this.setState({isOpenLinkInBrowser: true});
+    }
+
+    deeplinkNeedRedirectLoadingIndicator() {


NAB: rename for clarity that it returns a boolean

Suggested change

deeplinkNeedRedirectLoadingIndicator() {

shouldShowDeeplinkLoadingIndicator() {

I updated PR for above suggestion. Thank you

rushatgabhane · 2023-05-19T17:56:57Z

src/components/DeeplinkWrapper/index.website.js

+    }
+
+    deeplinkNeedRedirectLoadingIndicator() {
+        const validateLoginUrlPattern = '/v($|(//*))';


/v($|(//*))

@hoangzinh this can be move to CONST file -> REGEX

rushatgabhane · 2023-05-19T17:59:50Z

src/languages/en.js

@@ -170,6 +170,9 @@ export default {
        launching: 'Launching Expensify',
        expired: 'Your session has expired.',
        signIn: 'Please sign in again.',
+        redirectedToDesktopApp: "We've redirected you to the desktop app.",
+        youCanAlso: 'You can also',
+        openLinkInBrowser: 'open this link in your browser',


@hoangzinh has this been approved by any internal person?

Nah, I copied those text from previous PR https://github.com/Expensify/App/pull/16383/files#diff-22037c1e4dbdea8803b450b3fce06e6c475762a31ecf84b34dc264ba0e443637L158-L163

Basicallly this PR reimplement what we had before. So do I need to ask on Slack again? Or we can make decision here?

@hoangzinh thanks for confirming, sound good!

yeah i think this is fine

rushatgabhane · 2023-05-19T17:59:57Z

src/languages/es.js

@@ -169,6 +169,9 @@ export default {
        launching: 'Cargando Expensify',
        expired: 'Tu sesión ha expirado.',
        signIn: 'Por favor, inicia sesión de nuevo.',
+        redirectedToDesktopApp: 'Te hemos redirigido a la aplicación de escritorio.',
+        youCanAlso: 'También puedes',
+        openLinkInBrowser: 'abrir este enlace en tu navegador',


same with translations

rushatgabhane · 2023-05-19T18:41:38Z

@bondydaa The PR tests well! I didn't come across any errors that you've mentioned

Screen.Recording.2023-05-20.at.00.09.01.mov

rushatgabhane · 2023-05-19T18:46:14Z

but I still didn't get the prompt to open in app

@bondydaa you need to set the ENVIRONMENT to staging in your .env file.
Deeplink is disabled on dev because it's annoying if you're just testing web.

rushatgabhane · 2023-05-22T12:35:28Z

LGTM completing the checklist today

rushatgabhane · 2023-05-22T17:56:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-20.at.00.09.01.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

Screen.Recording.2023-05-20.at.00.09.01.mov

iOS

Android

rushatgabhane

@bondydaa LGTM!

hoangzinh · 2023-05-24T14:42:33Z

Bump for code review

bondydaa · 2023-05-25T20:09:45Z

great thanks for this, sorry for the delay. I'm going to pull and test again (with a fresh/clean onyx) but even if I still get errors I think we merge and see what QA finds.

bondydaa · 2023-05-25T20:18:32Z

Deeplink is disabled on dev because it's annoying if you're just testing web.

OH MY 🤦 def missed this

OSBotify · 2023-05-25T20:27:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-26T07:53:15Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.3.19-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-05-29T23:36:51Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.19-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

hoangzinh added 2 commits May 17, 2023 23:26

Implement DeeplinkRedirectLoadingIndicator component

f91caa5

Show deeplink redirect loading indicator for validate login url

0e86010

hoangzinh commented May 17, 2023

View reviewed changes

hoangzinh marked this pull request as ready for review May 17, 2023 17:22

hoangzinh requested a review from a team as a code owner May 17, 2023 17:22

melvin-bot bot requested review from bondydaa and rushatgabhane and removed request for a team May 17, 2023 17:22

hoangzinh mentioned this pull request May 17, 2023

[HOLD for payment 2023-06-05] [$1000] Desktop - Sign in - User can not validate an account #17724

Closed

6 tasks

rushatgabhane suggested changes May 19, 2023

View reviewed changes

hoangzinh added 2 commits May 20, 2023 10:31

Change state name

eb9df25

Add regex constant for validate login url

0fce612

Fix linter

c439f67

rushatgabhane approved these changes May 22, 2023

View reviewed changes

bondydaa approved these changes May 25, 2023

View reviewed changes

bondydaa merged commit 74b07d3 into Expensify:main May 25, 2023

OSBotify mentioned this pull request May 26, 2023

Deploy Checklist: New Expensify 2023-05-26 #19657

Closed

32 tasks

ntdiary mentioned this pull request May 26, 2023

clean up the deep link code #17452

Merged

56 tasks

bondydaa assigned hoangzinh May 26, 2023

hoangzinh mentioned this pull request May 26, 2023

[C+ Checklist Needs Completion] [$2000] Desktop - Secondary login successfully unlinked isn't displayed on Desktop App #19681

Closed

6 tasks

ntdiary mentioned this pull request May 31, 2023

Login - Infinity loading is displayed for open deep link on Desktop App #19860

Closed

6 tasks

hoangzinh mentioned this pull request Jun 23, 2023

[$1000] Sign In - Logo is displayed instead Abracadabra page #20999

Closed

6 tasks

getusha mentioned this pull request Sep 29, 2024

[NO QA]: migrate DeeplinkRedirectLoadingIndicator to useOnyx #49224

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix User can not validate an account in Desktop app #19125

Fix User can not validate an account in Desktop app #19125

hoangzinh commented May 17, 2023 •

edited

Loading

hoangzinh May 17, 2023

hoangzinh May 17, 2023

rushatgabhane May 19, 2023

hoangzinh May 20, 2023

melvin-bot bot commented May 17, 2023

hoangzinh commented May 18, 2023

bondydaa commented May 18, 2023

bondydaa commented May 18, 2023

bondydaa commented May 18, 2023

hoangzinh commented May 18, 2023

rushatgabhane left a comment •

edited

Loading

rushatgabhane May 19, 2023

hoangzinh May 20, 2023

rushatgabhane May 19, 2023

hoangzinh May 20, 2023

rushatgabhane May 19, 2023

rushatgabhane May 19, 2023

hoangzinh May 20, 2023

rushatgabhane May 22, 2023

bondydaa May 25, 2023

rushatgabhane May 19, 2023

rushatgabhane commented May 19, 2023

rushatgabhane commented May 19, 2023 •

edited

Loading

rushatgabhane commented May 22, 2023

rushatgabhane commented May 22, 2023 •

edited

Loading

rushatgabhane left a comment

hoangzinh commented May 24, 2023

bondydaa commented May 25, 2023

bondydaa commented May 25, 2023

OSBotify commented May 25, 2023

OSBotify commented May 26, 2023

OSBotify commented May 29, 2023

	deeplinkNeedRedirectLoadingIndicator() {
	shouldShowDeeplinkLoadingIndicator() {

Fix User can not validate an account in Desktop app #19125

Fix User can not validate an account in Desktop app #19125

Conversation

hoangzinh commented May 17, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melvin-bot bot commented May 17, 2023

hoangzinh commented May 18, 2023

bondydaa commented May 18, 2023

bondydaa commented May 18, 2023

bondydaa commented May 18, 2023

hoangzinh commented May 18, 2023

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rushatgabhane commented May 19, 2023

rushatgabhane commented May 19, 2023 • edited Loading

rushatgabhane commented May 22, 2023

rushatgabhane commented May 22, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane left a comment

Choose a reason for hiding this comment

hoangzinh commented May 24, 2023

bondydaa commented May 25, 2023

bondydaa commented May 25, 2023

OSBotify commented May 25, 2023

OSBotify commented May 26, 2023

OSBotify commented May 29, 2023

hoangzinh commented May 17, 2023 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

rushatgabhane commented May 19, 2023 •

edited

Loading

rushatgabhane commented May 22, 2023 •

edited

Loading