Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP Staging] Re-add old-style default avatar prefix #18369

Merged
merged 2 commits into from
May 3, 2023
Merged

[CP Staging] Re-add old-style default avatar prefix #18369

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7b447a
Re-add old-style default avatar prefix
francoisl May 3, 2023
4ff8ce5
Break down condition on multiple lines for linter
francoisl May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/libs/ReportUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,13 @@ function getOldDotDefaultAvatar(login = '') {
* @returns {Boolean}
*/
function isDefaultAvatar(avatarURL) {
if (_.isString(avatarURL) && (avatarURL.includes('images/avatars/default-avatar_') || avatarURL.includes('images/avatars/user/default'))) {
if (_.isString(avatarURL)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I broke this down on multiple lines for the linter. I followed the same pattern we do here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I think it is a stupid linter rule for code. I understand it for comments, but code should be able to be longer than 190 characters per line. But...that's a topic for a different day and time. :)

&& (
avatarURL.includes('images/avatars/avatar_')
|| avatarURL.includes('images/avatars/default-avatar_')
|| avatarURL.includes('images/avatars/user/default')
)
) {
return true;
}

Expand Down