[NoQA] Add falsey checks and `_.compact()` to places where we access SMS logins from personal details #18159

jasperhuangg · 2023-04-28T19:26:38Z

Details

Fixed Issues

https://expensify.slack.com/archives/C049HHMV9SM/p1682358290819999

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

…rom personal details

MelvinBot · 2023-04-28T19:36:45Z

@NikkiWines Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

neil-marcellini

Looking good, a couple things. Is there any way we can test this?

src/pages/ReportParticipantsPage.js

src/pages/DetailsPage.js

neil-marcellini · 2023-04-28T19:49:03Z

src/libs/LocalePhoneNumber.js

@@ -39,6 +39,10 @@ Onyx.connect({
 * @returns {String}
 */
 function formatPhoneNumber(number) {
+    if (!number) {
+        return '';


I think this is a good approach, but I'm unsure if it's going to be okay, in all uses, for it to be an empty string.

I originally had it to just return number, but my thinking was that if we're passed an incorrect falsey value (like undefined or 0 or something), it would be better to just return an empty string.

Yeah totally. What I'm saying is what will the caller of the function do with ''? Hopefully it's fine, but it's used all over the place so how do we verify that it works?

At least it definitely won't crash if we return '', since the caller expects a string.

github-actions · 2023-04-28T20:48:14Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

mountiny

I think this looks good, I will run a quick internal build os I can test this in web on my account

mountiny · 2023-04-28T20:52:51Z

Build here https://github.com/Expensify/App/actions/runs/4834671610

mountiny · 2023-04-28T20:52:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

I have tested just using the web build from above going to the lounge chat after signing in but I guess its hard to replicate, the app did not crash and seems to show all participants correctly so I will go ahead and merge this

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

neil-marcellini

I'm happy with the code, I have an idea to reproduce the error so I'll try testing really quickly.

neil-marcellini

I wasn't able to figure out how to test, I think we'll have to see how it works. The code looks good.

Add falsey checks and `_.compact()` to places where we access SMS logins from personal details (cherry picked from commit 237c8cd)

…-18159 🍒 Cherry pick PR #18159 to staging 🍒

OSBotify · 2023-04-28T21:44:12Z

🧪🧪 Use the links below to test this build in android and iOS. Happy testing! 🧪🧪

android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/18159/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/18159/index.html

desktop 💻	web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/18159/NewExpensify.dmg	https://18159.pr-testing.expensify.com

OSBotify · 2023-04-28T22:42:57Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.8-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-05-02T19:50:10Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.8-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-15T01:32:19Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:50:04Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

add falsey checks and compacts to places where we access SMS logins f…

fd43bee

…rom personal details

jasperhuangg self-assigned this Apr 28, 2023

jasperhuangg added 3 commits April 28, 2023 12:27

return empty string

51f4e5c

use value

3373f44

fix typo

27b0d47

jasperhuangg changed the title ~~Add falsey checks and compacts to places where we access SMS logins from personal details~~ Add falsey checks and _.compact() to places where we access SMS logins from personal details Apr 28, 2023

jasperhuangg marked this pull request as ready for review April 28, 2023 19:36

jasperhuangg requested a review from a team as a code owner April 28, 2023 19:36

melvin-bot bot requested review from NikkiWines and removed request for a team April 28, 2023 19:36

neil-marcellini requested changes Apr 28, 2023

View reviewed changes

jasperhuangg added 2 commits April 28, 2023 12:57

fix isSMSLogin usages

caa86c4

use chain correctly

5cb8198

jasperhuangg requested a review from neil-marcellini April 28, 2023 20:05

mountiny added the CP Staging label Apr 28, 2023

mountiny approved these changes Apr 28, 2023

View reviewed changes

mountiny added the Ready To Build label Apr 28, 2023

neil-marcellini reviewed Apr 28, 2023

View reviewed changes

neil-marcellini approved these changes Apr 28, 2023

View reviewed changes

mountiny merged commit 237c8cd into main Apr 28, 2023

mountiny deleted the jasper-addFalseyChecks branch April 28, 2023 21:30

mountiny changed the title ~~Add falsey checks and _.compact() to places where we access SMS logins from personal details~~ [NoQA] Add falsey checks and _.compact() to places where we access SMS logins from personal details Apr 28, 2023

jasperhuangg mentioned this pull request Apr 28, 2023

[NoQA] Remove unnecessary participants filtering #18173

Merged

56 tasks

OSBotify pushed a commit that referenced this pull request Apr 28, 2023

Merge pull request #18159 from Expensify/jasper-addFalseyChecks

36953e2

Add falsey checks and `_.compact()` to places where we access SMS logins from personal details (cherry picked from commit 237c8cd)

OSBotify mentioned this pull request Apr 28, 2023

🍒 Cherry pick PR #18159 to staging 🍒 #18175

Merged

OSBotify added a commit that referenced this pull request Apr 28, 2023

Merge pull request #18175 from Expensify/OSBotify-cherry-pick-staging…

f31cb46

…-18159 🍒 Cherry pick PR #18159 to staging 🍒

OSBotify mentioned this pull request Apr 28, 2023

Deploy Checklist: New Expensify 2023-04-28 #18132

Closed

30 tasks

This was referenced May 2, 2023

Deploy Checklist: New Expensify 2023-05-02 #18315

Closed

Deploy Checklist: New Expensify 2023-05-02 #18322

Closed

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NoQA] Add falsey checks and `_.compact()` to places where we access SMS logins from personal details #18159

[NoQA] Add falsey checks and `_.compact()` to places where we access SMS logins from personal details #18159

jasperhuangg commented Apr 28, 2023 •

edited

Loading

MelvinBot commented Apr 28, 2023

neil-marcellini left a comment

neil-marcellini Apr 28, 2023

jasperhuangg Apr 28, 2023

neil-marcellini Apr 28, 2023

jasperhuangg Apr 28, 2023

github-actions bot commented Apr 28, 2023

mountiny left a comment

mountiny commented Apr 28, 2023

mountiny commented Apr 28, 2023 •

edited

Loading

neil-marcellini left a comment

neil-marcellini left a comment

OSBotify commented Apr 28, 2023

OSBotify commented Apr 28, 2023

OSBotify commented May 2, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

[NoQA] Add falsey checks and _.compact() to places where we access SMS logins from personal details #18159

[NoQA] Add falsey checks and _.compact() to places where we access SMS logins from personal details #18159

Conversation

jasperhuangg commented Apr 28, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Apr 28, 2023

neil-marcellini left a comment

Choose a reason for hiding this comment

neil-marcellini Apr 28, 2023

Choose a reason for hiding this comment

jasperhuangg Apr 28, 2023

Choose a reason for hiding this comment

neil-marcellini Apr 28, 2023

Choose a reason for hiding this comment

jasperhuangg Apr 28, 2023

Choose a reason for hiding this comment

github-actions bot commented Apr 28, 2023

mountiny left a comment

Choose a reason for hiding this comment

mountiny commented Apr 28, 2023

mountiny commented Apr 28, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

neil-marcellini left a comment

Choose a reason for hiding this comment

neil-marcellini left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 28, 2023

OSBotify commented Apr 28, 2023

OSBotify commented May 2, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

[NoQA] Add falsey checks and `_.compact()` to places where we access SMS logins from personal details #18159

[NoQA] Add falsey checks and `_.compact()` to places where we access SMS logins from personal details #18159

jasperhuangg commented Apr 28, 2023 •

edited

Loading

mountiny commented Apr 28, 2023 •

edited

Loading