Always display workspace chats in recents when creating a new request #16967

marcaaron · 2023-04-05T17:33:45Z

Details

Doc section here:

https://docs.google.com/document/d/17jFcMsAotXvsMhXivoF3u7fyzeyXkKpRGXR88Ud0oWY/edit#bookmark=kix.mwuwbgdkfhxc

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/270684

Tests

Login as a new user (ADMIN) who does not yet have a workspace
Create a workspace and invite another new user (EMPLOYEE)
Verify the ADMIN can see in the LHN a Workspace Chat (Chat 1) for themselves and a Workspace Chat for the EMPLOYEE
Run through the following flows and verify...

Search -> Both Chats appear
LHN -> Both Chats appear
Request money -> Only the user's OWN workspace chat appears (not the managed one)
New chat -> None
New group -> None
Send money -> None
Split bill -> None

Login next as the EMPLOYEE
Verify they can only see their OWN workspace chat
Run through the following flows and verify...

Search -> Own Chat appears
LHN -> Own Chat appears
Request money -> Own Chat appears
New chat -> None
New group -> None
Send money -> None
Split bill -> None

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

…s no differnece

marcaaron · 2023-04-05T17:47:02Z

Still need to test and write up manual QA, but this should be ready I think...

src/pages/iou/steps/IOUParticipantsPage/IOUParticipantsRequest.js

Julesssss · 2023-04-05T21:31:30Z

src/pages/iou/steps/IOUParticipantsPage/IOUParticipantsRequest.js

+            // If we are using this component in the "Request money" flow then we pass the includeOwnedWorkspaceChats argument so that the current user
+            // sees the option to request money from their admin on their own Workspace Chat. These will always be shown in the "Recents" section of the selector
+            // along with any other recent chats.


mountiny · 2023-04-05T21:54:39Z

Yeah i think the comment is great.

We should also keep in mind that contributors have little context about our roadmap and internal terms so the more specific we are the easier it will be for external people to understand whats going on

marcaaron · 2023-04-05T23:09:05Z

Still testing, but taking this out of WIP.

MelvinBot · 2023-04-05T23:09:23Z

@fedirjh @roryabraham One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

marcaaron · 2023-04-05T23:21:12Z

Done testing. Ready for review.

fedirjh · 2023-04-06T00:06:24Z

@marcaaron code LGTM ,For testing, does it require access to the policyExpenseChat beta ? I have tested with regular accounts and some tests are failing for me.

0xmiros · 2023-04-06T03:17:47Z

@marcaaron code LGTM ,For testing, does it require access to the policyExpenseChat beta ? I have tested with regular accounts and some tests are failing for me.

@fedirjh Good timing 🙂 https://expensify.slack.com/archives/C02NK2DQWUX/p1680733162617359?thread_ts=1680200377.348429&cid=C02NK2DQWUX

src/libs/OptionsListUtils.js

mountiny · 2023-04-06T12:47:04Z

@fedirjh your account should be on the beta now!

src/libs/OptionsListUtils.js

fedirjh · 2023-04-06T15:58:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Admin Tests

Employee Tests

Screen.Recording.2023-04-06.at.4.48.18.PM.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

Screen.Recording.2023-04-06.at.3.50.57.PM.mov

iOS

Simulator.Screen.Recording.-.iPhone.14.-.2023-04-06.at.16.07.28.mp4

Android

fedirjh · 2023-04-06T15:59:14Z

@marcaaron tests LGTM , however I noticed that archived workspaces are also listed in the Request money flow

List	Preview

marcaaron · 2023-04-06T16:00:29Z

Oh hmm lemme fix that archived workspaces thing. I think I'd agree that should not be visible.

marcaaron · 2023-04-06T16:15:11Z

Updated

mountiny · 2023-04-06T16:15:42Z

Great find, definitely should not be there

mountiny

Looks good to me, @fedirjh waiting for your sign off 🖖

fedirjh · 2023-04-06T16:29:59Z

@marcaaron Now i got this error 🥲

marcaaron · 2023-04-06T16:33:08Z

@fedirjh repro steps please

MelvinBot · 2023-04-06T16:35:03Z

🎯 @fedirjh, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #17083.

marcaaron · 2023-04-06T16:35:04Z

Oh I see it... 👀

mountiny · 2023-04-06T16:35:47Z

Did you approve this by accident @fedirjh ?

fedirjh · 2023-04-06T16:37:45Z

@marcaaron All good , I request money from the archived room before I test the update , logout and login and it's working fine .

Edit : Sorry guys I should’ve commented before I approve.

marcaaron · 2023-04-06T16:41:54Z

Ok cool cool - yeah reproduced it the same way. I don't think we can actually request money from a room yet this is just a step towards the goal.

marcaaron · 2023-04-06T16:43:16Z

OSBotify · 2023-04-06T16:47:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-04-07T23:02:34Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.2.97-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-04-10T18:28:08Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.2.97-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

marcaaron added 3 commits April 5, 2023 06:59

Always display workspace chats in recents when creating a new request

99baa9f

Change to include idk maybe its easier to understand or at least make…

d59394a

…s no differnece

Update constants

ec7b3ab

marcaaron self-assigned this Apr 5, 2023

marcaaron requested review from mountiny and Julesssss April 5, 2023 17:34

remove bit about managedWorkspaceChats these are not showing up anyway

a953501

mountiny requested changes Apr 5, 2023

View reviewed changes

src/pages/iou/steps/IOUParticipantsPage/IOUParticipantsRequest.js Outdated Show resolved Hide resolved

mountiny reviewed Apr 5, 2023

View reviewed changes

src/pages/iou/steps/IOUParticipantsPage/IOUParticipantsRequest.js Outdated Show resolved Hide resolved

marcaaron added 2 commits April 5, 2023 08:55

fix linter

f278d8d

Maybe too wordy. But Vit is a good editor.

ed3b3e8

Julesssss reviewed Apr 5, 2023

View reviewed changes

marcaaron changed the title ~~[WIP] Always display workspace chats in recents when creating a new request~~ Always display workspace chats in recents when creating a new request Apr 5, 2023

marcaaron marked this pull request as ready for review April 5, 2023 23:08

marcaaron requested a review from a team as a code owner April 5, 2023 23:08

melvin-bot bot requested review from fedirjh and roryabraham and removed request for a team April 5, 2023 23:09

marcaaron requested review from mountiny and Julesssss April 5, 2023 23:20

Julesssss reviewed Apr 6, 2023

View reviewed changes

src/libs/OptionsListUtils.js Show resolved Hide resolved

mountiny reviewed Apr 6, 2023

View reviewed changes

src/libs/OptionsListUtils.js Show resolved Hide resolved

src/libs/OptionsListUtils.js Show resolved Hide resolved

Remove archived from the Request money list

f5bce61

marcaaron requested review from mountiny and Julesssss April 6, 2023 16:15

mountiny approved these changes Apr 6, 2023

View reviewed changes

Julesssss approved these changes Apr 6, 2023

View reviewed changes

fedirjh approved these changes Apr 6, 2023

View reviewed changes

melvin-bot bot mentioned this pull request Apr 6, 2023

[Hold for payment 2023-04-17] Payment issue for E/App PR#16967 #17083

Closed

marcaaron merged commit f328f44 into main Apr 6, 2023

marcaaron deleted the marcaaron-workspaceChatsInNewRequest branch April 6, 2023 16:43

OSBotify mentioned this pull request Apr 7, 2023

Deploy Checklist: New Expensify 2023-04-07 #17160

Closed

23 tasks

abdulrahuman5196 mentioned this pull request Jun 19, 2023

[HOLD for payment 2023-07-14] [$1000] Able to request money from Workspaces in main #20830

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Always display workspace chats in recents when creating a new request #16967

Always display workspace chats in recents when creating a new request #16967

marcaaron commented Apr 5, 2023 •

edited

Loading

marcaaron commented Apr 5, 2023

Julesssss Apr 5, 2023

mountiny commented Apr 5, 2023

marcaaron commented Apr 5, 2023

MelvinBot commented Apr 5, 2023

marcaaron commented Apr 5, 2023

fedirjh commented Apr 6, 2023 •

edited

Loading

0xmiros commented Apr 6, 2023

mountiny commented Apr 6, 2023

fedirjh commented Apr 6, 2023

fedirjh commented Apr 6, 2023

marcaaron commented Apr 6, 2023

marcaaron commented Apr 6, 2023

mountiny commented Apr 6, 2023

mountiny left a comment

fedirjh commented Apr 6, 2023

marcaaron commented Apr 6, 2023

MelvinBot commented Apr 6, 2023

marcaaron commented Apr 6, 2023

mountiny commented Apr 6, 2023

fedirjh commented Apr 6, 2023 •

edited

Loading

marcaaron commented Apr 6, 2023

marcaaron commented Apr 6, 2023

OSBotify commented Apr 6, 2023

OSBotify commented Apr 7, 2023

OSBotify commented Apr 10, 2023

Always display workspace chats in recents when creating a new request #16967

Always display workspace chats in recents when creating a new request #16967

Conversation

marcaaron commented Apr 5, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

marcaaron commented Apr 5, 2023

Julesssss Apr 5, 2023

Choose a reason for hiding this comment

mountiny commented Apr 5, 2023

marcaaron commented Apr 5, 2023

MelvinBot commented Apr 5, 2023

marcaaron commented Apr 5, 2023

fedirjh commented Apr 6, 2023 • edited Loading

0xmiros commented Apr 6, 2023

mountiny commented Apr 6, 2023

fedirjh commented Apr 6, 2023

Reviewer Checklist

Screenshots/Videos

fedirjh commented Apr 6, 2023

marcaaron commented Apr 6, 2023

marcaaron commented Apr 6, 2023

mountiny commented Apr 6, 2023

mountiny left a comment

Choose a reason for hiding this comment

fedirjh commented Apr 6, 2023

marcaaron commented Apr 6, 2023

MelvinBot commented Apr 6, 2023

marcaaron commented Apr 6, 2023

mountiny commented Apr 6, 2023

fedirjh commented Apr 6, 2023 • edited Loading

marcaaron commented Apr 6, 2023

marcaaron commented Apr 6, 2023

OSBotify commented Apr 6, 2023

OSBotify commented Apr 7, 2023

OSBotify commented Apr 10, 2023

marcaaron commented Apr 5, 2023 •

edited

Loading

fedirjh commented Apr 6, 2023 •

edited

Loading

fedirjh commented Apr 6, 2023 •

edited

Loading