Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IS-1500] Fixed compose field alignment issue #1557

Merged
merged 2 commits into from
Feb 25, 2021
Merged

[IS-1500] Fixed compose field alignment issue #1557

merged 2 commits into from
Feb 25, 2021

Conversation

aliabbasmalik8
Copy link
Contributor

@aliabbasmalik8 aliabbasmalik8 commented Feb 24, 2021 •
edited
Loading

Details

Added textInputAlignSelf utility for textInputCompose style object.

Fixed Issues

Fixes #1500

Tests

Please look at message compose box now text inside of the compose box is aligned.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

image

Desktop

image

iOS

image

Android

image

@aliabbasmalik8 aliabbasmalik8 requested a review from a team as a code owner February 24, 2021 18:10
@botify botify requested review from thienlnam and removed request for a team February 24, 2021 18:10
thienlnam
thienlnam approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@thienlnam thienlnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Tests well

@thienlnam thienlnam merged commit e649807 into Expensify:master Feb 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2021
@trjExpensify
Copy link
Contributor

trjExpensify commented Nov 15, 2022 •
edited
Loading

👋 Heads up! As per the new BugZero checklist. Commenting to surface that this introduced a regression on iOS outlined here.

CC: @Julesssss @Santhosh-Sellavel @fedirjh

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thienlnam thienlnam thienlnam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Padding and alignment on compose field for iOS looks misaligned
3 participants
@aliabbasmalik8 @trjExpensify @thienlnam