fix/14842: Message sent is not updated in the search page when a new message arrives

[tienifr]

Details

When the reports, personalDetails, betas props changes, we need to update the subtitle of the option (it is the last message with this user) and displayName. So, we need to update the option list when some props change. This PR does that

Fixed Issues

$ #14842
$ #14842 (comment)

Tests

1. Login with user A
2. Login with user B in another browser or device
3. Open the search page on the device where user A is logged in
4. We will have 2 cases to test
   Case 1: Send a message from user B to user A and verify that the subtitle of UserB's option is updated immediately
   Case 2: Update the display name in user B and verify that the display name of UserB's option is updated immediately

• Verify that no errors appear in the JS console

Offline tests

QA Steps

1. Login with user A
2. Login with user B in another browser or device
3. Open the search page on the device where user A is logged in
4. We will have 2 cases to test
   Case 1: Send a message from user B to user A and verify that the subtitle of UserB's option is updated immediately
   Case 2: Update the display name in user B and verify that the display name of UserB's option is updated immediately

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-02-10.at.10.37.55.mp4

Mobile Web - Chrome

329290413_9024525117587622_5147537344537907453_n.mp4

Mobile Web - Safari

Screen.Recording.2023-02-10.at.10.45.12.mp4

Desktop

Screen.Recording.2023-02-10.at.10.47.40.mp4

iOS

Screen.Recording.2023-02-10.at.10.54.52.mp4

Android

Screen.Recording.2023-02-10.at.11.10.33.mp4

[MelvinBot]

@puneetlath @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[thesahindia]

We can just check for the whole prop object like you had proposed, I don't feel this is something significant.
I will defer to @puneetlath on this.

[tienifr]

@thesahindia I just fixed it

[thesahindia]

@puneetlath, I think we need to take a second look at this. I just checked other pages and this issue is present there as well. If a user updates their name the name doesn't change in invite members page and new chat/group page as well. I think we should look for a better solution which doesn't revolve around updating the state. I think we should close this PR for now, update the issue and start over.

[puneetlath]

It's a fair question of whether its even worth updating these more "temporary" style search dialogs with the latest data given that they aren't really static pages, but dialogs you interact with temporarily.

Let's start a discussion in #open-source about it.

Don't worry @tienifr you will be compensated for your work no matter what we ultimately decide.

[thesahindia]

Let's start a discussion in #open-source about it.

Starting the discussion shortly
Discussion here

[puneetlath]

Ok let's go ahead and close this PR as we've decided not to fix.