Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace double newlines with a single newline #13739

Merged
merged 8 commits into from
Jan 10, 2023
Merged

Replace double newlines with a single newline #13739

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a95ddfc
Replace double newlines with a single newline
tgolen Dec 20, 2022
de90a62
Change "newlines" to "new lines"
tgolen Dec 20, 2022
6b69596
Add extra newlines when copying from context-menu
tgolen Dec 28, 2022
dba3cf8
Merge branch 'main' into tgolen-fix-paste-extra-lines
tgolen Jan 2, 2023
19b6546
Move the place where newlines are doubled
tgolen Jan 3, 2023
5ff34b5
Add another place where newlines are removed
tgolen Jan 5, 2023
c778843
Remove unused imports
tgolen Jan 5, 2023
cb94d2b
Fix removal of newlines when copying inside the composer
tgolen Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/Composer/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,9 @@ class Composer extends React.Component {
return;
}

const plainText = event.clipboardData.getData('text/plain');
// The regex replace is there because when doing a "paste without formatting", there are extra line breaks added to the content (I do not know why). To fix the problem, anytime
// there is a double set of new lines, they are replaced with a single new line. This preserves the same number of new lines between pasting with and without formatting.
const plainText = event.clipboardData.getData('text/plain').replace(/\n\n/g, '\n');
this.paste(Str.htmlDecode(plainText));
}

Expand Down