-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade react-native to Expensify version 0.70.5 #11975
Conversation
Tested, and felt some scroll issues on the web which exist on staging, the comparison is shown in the recording also. iOS recording felt chunky but mWeb, feels like a simulator problem. I checked on the other branch behavior is the same. WebScreen.Recording.2022-10-20.at.12.35.07.AM.movDesktopScreen.Recording.2022-10-20.at.12.36.40.AM.movAndroidScreen.Recording.2022-10-20.at.12.38.17.AM.moviOS and mWebScreen.Recording.2022-10-20.at.12.35.07.AM.mov |
👀 🎀 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Test well. No new issues, scrolling feels faster & smoother now.
cc @chiragsalian btw this brings Fabric support for bidirectional scrolling 🎉 |
I'm hype 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@techievivek looks like this was merged without the checklist test passing. Please add a note explaining why this was done and remove the |
Not an emergency merge. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @techievivek in version: 1.2.19-0 🚀
|
🚀 Deployed to production by @chiragsalian in version: 1.2.19-2 🚀
|
Details
This PR upgrades our app to use version
0.70.5
of our React Native fork. This adds Fabric support for our bidirectional pagination features.Fixed Issues
$ (partial) #8503
Tests / QA Steps
PR Review Checklist
PR Author Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Screenshots
Web
Screen.Recording.2022-10-19.at.12.08.20.AM.mov
Mobile Web - Chrome
screen-20221019-001219.mp4
Mobile Web - Safari
RPReplay_Final1666163442.MP4
Desktop
Screen.Recording.2022-10-19.at.12.12.51.AM.mov
iOS
RPReplay_Final1666164432.MP4
Android
screen-20221019-001949_2.mp4