Render Emoji when typed with emoji code #10165

Karim-30 · 2022-08-01T17:06:40Z

Details

this PR makes it possible to see emojis when typing the emoji code inside ::, for example, if you type Hi :smile: in the Composer you should see Hi 😄 not Hi :smile:.

Fixed Issues

$ #4324
$ #4324 (comment)

Tests

Go to the chat
Enter Hi :smile:.
Verify you are seeing Hi 😄 not Hi :smile:.

Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

Go to the chat
Enter Hi :smile:.
Verify you are seeing Hi 😄 not Hi :smile:.

Verify that no errors appear in the JS console

Screenshots

Web

web.mov

Mobile Web - Chrome

mweb.chrome.mov

Mobile Web - Safari

mweb.mov

Desktop

Desktop.mov

iOS

IOS.mov

Android

android.mov

src/libs/EmojisTrie.js

src/pages/home/report/ReportActionCompose.js

src/pages/home/report/ReportActionItemMessageEdit.js

…ender_emoji

src/libs/EmojiTrieNode.js

src/pages/home/report/ReportActionCompose.js

roryabraham · 2022-08-02T23:25:27Z

I also think unit tests would be really valuable here.

Santhosh-Sellavel · 2022-08-03T14:51:16Z

I also think unit tests would be really valuable here.

Ya makes sense!

src/libs/Trie.js

src/libs/TrieNode.js

src/pages/home/report/ReportActionCompose.js

src/pages/home/report/ReportActionItemMessageEdit.js

roryabraham

Also, I think it would be useful to implement a method called getAllMatchingWords(substr) that:

Finds the node matching the substring
Finds all leaf nodes that are children of that substring and returns them as an array.

So for example, given a Trie containing the words cape and cats, we would expect to see a Trie like this:

        c
        |
        a
      /   \
     p     t
   /        \
  e          s

So if we ran getAllMatchingWords('ca') we would get ['cape', 'cats'] back.

src/libs/TrieNode.js

src/libs/Trie.js

tests/unit/EmojiTrieTest.js

Santhosh-Sellavel · 2022-08-09T21:16:48Z

@Karim-30 Any update?

Karim-30 · 2022-08-09T21:58:58Z

@Santhosh-Sellaveltomorrow inshallah.

src/libs/Trie/index.js

roryabraham · 2022-10-19T21:27:29Z

@Santhosh-Sellavel I think you're the assigned C+ for this PR, so let's prioritize getting it reviewed and tested soon. It has been open a long time so would be great to get it over the finish line

rushatgabhane

tests well! cc @Santhosh-Sellavel

(sidenote im not the c+ here)

Santhosh-Sellavel · 2022-10-20T02:10:08Z

Reviewing this now

Santhosh-Sellavel · 2022-10-20T02:18:23Z

PR Reviewer Checklist

C+ Reviewed 🎀 👀 🎀 The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Santhosh-Sellavel

LGTM, tests well!

rushatgabhane · 2022-10-20T06:03:58Z

@Santhosh-Sellavel you need to add screenshots for all platforms as part of a change to the checklist

Santhosh-Sellavel · 2022-10-20T15:54:13Z

Oh Crap ya I missed that, will do that later today, AFK now.

Santhosh-Sellavel · 2022-10-20T19:08:46Z

@roryabraham @stitesExpensify

Android

Screen.Recording.2022-10-21.at.12.36.42.AM.mov

iOS & mWeb

Simulator.Screen.Recording.-.iPhone.13.-.2022-10-21.at.00.33.44.mp4

Desktop & Web

Screen.Recording.2022-10-21.at.12.31.14.AM.mov

stitesExpensify · 2022-10-20T19:46:50Z

Woohoo! Let's ship it!

melvin-bot · 2022-10-20T19:47:06Z

@stitesExpensify looks like this was merged without the checklist test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

stitesExpensify · 2022-10-20T19:47:25Z

Tests had passed. :that: is a bug

OSBotify · 2022-10-20T19:51:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-10-25T00:13:53Z

🚀 Deployed to staging by @stitesExpensify in version: 1.2.19-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-10-26T22:33:17Z

🚀 Deployed to production by @chiragsalian in version: 1.2.19-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

parasharrajat · 2023-03-03T19:38:56Z

Heads up! This PR caused one issue #14876. We forgot to test skin tone for emojis on this.

Karim-30 · 2023-03-05T19:51:26Z

@parasharrajat We built EmojiTrie to be used in replacing the emoji code with its emoji, skin tone was out of the scope.

parasharrajat · 2023-03-05T20:34:31Z

Can you share a link to the comment where it was mentioned out of scope?

render emoji when typing the emoji code

00c4e27

Karim-30 requested a review from a team as a code owner August 1, 2022 17:06

melvin-bot bot requested review from Santhosh-Sellavel and stitesExpensify and removed request for a team August 1, 2022 17:06

Santhosh-Sellavel suggested changes Aug 2, 2022

View reviewed changes

Karim-30 added 3 commits August 2, 2022 22:27

Merge branch 'Expensify:main' into render_emoji

fe70b1f

make a separate TrieNode class file

fbceff8

Merge branch 'render_emoji' of https://github.com/Karim-30/App into r…

736f5ce

…ender_emoji

roryabraham requested changes Aug 2, 2022

View reviewed changes

src/libs/EmojiTrieNode.js Outdated Show resolved Hide resolved

src/pages/home/report/ReportActionCompose.js Outdated Show resolved Hide resolved

src/pages/home/report/ReportActionCompose.js Outdated Show resolved Hide resolved

Karim-30 added 3 commits August 3, 2022 20:27

retrive empty line comments

5f0f994

add unit tests

d36d981

add unit tests

994e08d

Santhosh-Sellavel suggested changes Aug 4, 2022

View reviewed changes

Karim-30 added 3 commits August 5, 2022 07:24

remove emoji keyword from Trie and Trie node

46f67e9

Merge branch 'Expensify:main' into render_emoji

3e1bb7a

remove emoji keyword from TrieNode file and fix return typo

43fa12d

Karim-30 requested a review from roryabraham August 8, 2022 14:48

stitesExpensify assigned Karim-30 Aug 8, 2022

roryabraham requested changes Aug 8, 2022

View reviewed changes

Karim-30 added 4 commits August 10, 2022 16:47

remove emoji keyword from TrieNode file and fix return typo

08bd89c

Add search feature and some improvements to the Trie

db64e0e

Add search feature and some improvements to the Trie

cafe68f

Remove Trie and TrieNode files from src/lib folder

b4352b8

Karim-30 requested a review from roryabraham August 11, 2022 10:06

Santhosh-Sellavel suggested changes Aug 15, 2022

View reviewed changes

src/libs/Trie/index.js Outdated Show resolved Hide resolved

Karim-30 dismissed stale reviews from stitesExpensify and roryabraham via 4f790a8 October 19, 2022 06:17

roryabraham approved these changes Oct 19, 2022

View reviewed changes

rushatgabhane approved these changes Oct 19, 2022

View reviewed changes

stitesExpensify approved these changes Oct 19, 2022

View reviewed changes

Santhosh-Sellavel approved these changes Oct 20, 2022

View reviewed changes

stitesExpensify merged commit 1140eec into Expensify:main Oct 20, 2022

melvin-bot bot added the Emergency label Oct 20, 2022

stitesExpensify removed the Emergency label Oct 20, 2022

OSBotify mentioned this pull request Oct 24, 2022

Deploy Checklist: New Expensify 2022-10-24 #12108

Closed

45 tasks

melvin-bot bot mentioned this pull request Oct 26, 2022

[HOLD for payment 2022-11-02] [$2000] Render Emoji when typed with emoji code #4324

Closed

stitesExpensify mentioned this pull request Oct 31, 2022

Efficiently store and search for emojis #12189

Closed

stitesExpensify mentioned this pull request Jan 6, 2023

[HOLD for payment 2023-03-21] [$1000] [Feature] Create autosuggestion UI for :emoji_codes: #12188

Closed

parasharrajat mentioned this pull request Mar 3, 2023

[HOLD for payment 2023-02-28] [$1000] Emoji skin tone colors aren't working/updating #14876

Closed

2 tasks

s77rt mentioned this pull request Apr 5, 2023

[HOLD for payment 2023-04-12] [$1000] Web -If even the tone of the emoji is dark, the emoji that sent via emoji code is in light tone #15805

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Render Emoji when typed with emoji code #10165

Render Emoji when typed with emoji code #10165

Karim-30 commented Aug 1, 2022 •

edited

Loading

roryabraham commented Aug 2, 2022

Santhosh-Sellavel commented Aug 3, 2022

roryabraham left a comment

Santhosh-Sellavel commented Aug 9, 2022

Karim-30 commented Aug 9, 2022

roryabraham commented Oct 19, 2022

rushatgabhane left a comment •

edited

Loading

Santhosh-Sellavel commented Oct 20, 2022

Santhosh-Sellavel commented Oct 20, 2022 •

edited

Loading

PR Reviewer Checklist

Santhosh-Sellavel left a comment

rushatgabhane commented Oct 20, 2022

Santhosh-Sellavel commented Oct 20, 2022 •

edited

Loading

Santhosh-Sellavel commented Oct 20, 2022

stitesExpensify commented Oct 20, 2022

melvin-bot bot commented Oct 20, 2022

stitesExpensify commented Oct 20, 2022

OSBotify commented Oct 20, 2022

OSBotify commented Oct 25, 2022

OSBotify commented Oct 26, 2022

parasharrajat commented Mar 3, 2023

Karim-30 commented Mar 5, 2023

parasharrajat commented Mar 5, 2023

Render Emoji when typed with emoji code #10165

Render Emoji when typed with emoji code #10165

Conversation

Karim-30 commented Aug 1, 2022 • edited Loading

Details

Fixed Issues

Tests

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

roryabraham commented Aug 2, 2022

Santhosh-Sellavel commented Aug 3, 2022

roryabraham left a comment

Choose a reason for hiding this comment

Santhosh-Sellavel commented Aug 9, 2022

Karim-30 commented Aug 9, 2022

roryabraham commented Oct 19, 2022

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

Santhosh-Sellavel commented Oct 20, 2022

Santhosh-Sellavel commented Oct 20, 2022 • edited Loading

PR Reviewer Checklist

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

rushatgabhane commented Oct 20, 2022

Santhosh-Sellavel commented Oct 20, 2022 • edited Loading

Santhosh-Sellavel commented Oct 20, 2022

Android

iOS & mWeb

Desktop & Web

stitesExpensify commented Oct 20, 2022

melvin-bot bot commented Oct 20, 2022

stitesExpensify commented Oct 20, 2022

OSBotify commented Oct 20, 2022

OSBotify commented Oct 25, 2022

OSBotify commented Oct 26, 2022

parasharrajat commented Mar 3, 2023

Karim-30 commented Mar 5, 2023

parasharrajat commented Mar 5, 2023

Karim-30 commented Aug 1, 2022 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

Santhosh-Sellavel commented Oct 20, 2022 •

edited

Loading

Santhosh-Sellavel commented Oct 20, 2022 •

edited

Loading