Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$500] Long workspace name breaks the alignment of side arrow - @Tushu17 #8461

Closed
mvtglobally opened this issue Apr 4, 2022 · 41 comments
Closed

[$500] Long workspace name breaks the alignment of side arrow - @Tushu17 #8461

mvtglobally opened this issue Apr 4, 2022 · 41 comments
Assignees
@arielgreen @Santhosh-Sellavel
Labels
Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@mvtglobally
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Create a workspace
  2. Go to General Settings
  3. Use a long name for workspace
  4. Now go to settings and see the arrow at the right side of workspace.

Expected Result:

It shouldn't break the alignment of the side arrows.

Actual Result:

Long workspace name disturb the alignment of the side arrow of workspace.

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.1.46-1
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
image - 2022-04-04T001410 986

Expensify/Expensify Issue URL:
Issue reported by: @Tushu17
Slack conversation:
https://expensify.slack.com/archives/C01GTK53T8Q/p1648247302114379

View all open jobs on GitHub
@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Apr 4, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 4, 2022

Triggered auto assignment to @muttmuure (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot added Overdue and removed AutoAssignerTriage Auto assign issues for triage to an available triage team member labels Apr 4, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 7, 2022

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot melvin-bot bot removed Overdue labels Apr 7, 2022
@roryabraham roryabraham added the External Added to denote the issue can be worked on by a contributor label Apr 7, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 7, 2022

Triggered auto assignment to @arielgreen (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@arielgreen
Copy link
Contributor

https://www.upwork.com/jobs/~017410ee10e9594e18

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 7, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 7, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 7, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 7, 2022

Current assignee @roryabraham is eligible for the Exported assigner, not assigning anyone new.

@melvin-bot melvin-bot bot changed the title Long workspace name breaks the alignment of side arrow - @Tushu17 [$250] Long workspace name breaks the alignment of side arrow - @Tushu17 Apr 7, 2022
@nadir
Copy link

nadir commented Apr 8, 2022

I was able to fix this by setting flex-shrink to 1 on the container view
image

@roryabraham
Copy link
Contributor

Nice! LGTM 👍

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 8, 2022
@arielgreen arielgreen changed the title [$250] Long workspace name breaks the alignment of side arrow - @Tushu17 [$500] Long workspace name breaks the alignment of side arrow - @Tushu17 May 3, 2022
@arielgreen
Copy link
Contributor

Price increased.

@Santhosh-Sellavel
Copy link
Collaborator

Santhosh-Sellavel commented May 4, 2022 •
edited
Loading

I’m not able to reproduce this even once, were you able to reproduce @roryabraham?

@mvtglobally & @Tushu17 Is this occurring consistently for you all. If then Please share the following info: Platform: In Mac or Windows Browser: Display Size in inches: Thanks!

Is this reproducible?

@Tushu17
Copy link
Contributor

Tushu17 commented May 4, 2022

Is this reproducible?

Yes @Santhosh-Sellavel It's still reproducible in Window on chrome.

@Santhosh-Sellavel
Copy link
Collaborator

Windows OS?

@Tushu17
Copy link
Contributor

Tushu17 commented May 4, 2022

Windows OS?

@Santhosh-Sellavel Yes

@jayeshmangwani
Copy link
Contributor

App/src/components/MenuItem.js

Line 62 in 569289b

<View style={[styles.flexRow, styles.pointerEventsNone]}>

adding flex: 1 at the parent of the title is fixing this issue

Before this change
Screenshot 2022-05-05 at 1 47 14 AM

After this change
Screenshot 2022-05-05 at 1 48 11 AM

@Santhosh-Sellavel
Copy link
Collaborator

Thanks, @Tushu17, I was able to reproduce this one, on chrome (Windows).
The issue exists on staging but is no longer reproducible in the main branch. Check out the video in the slack thread!

cc: @roryabraham

@roryabraham
Copy link
Contributor

@Santhosh-Sellavel can you please retest on staging today? There was a staging deploy yesterday, so the main branch was deployed to staging environment.

@Santhosh-Sellavel
Copy link
Collaborator

Issue unable to reproduce for me on staging. @Tushu17 can you confirm the same?

@jayeshmangwani
Copy link
Contributor

@Santhosh-Sellavel @roryabraham
I think this commit is fixing this issue 388cfe3

this change I already commented but I think this change was already done before my comment

#8461 (comment)

@Tushu17
Copy link
Contributor

Tushu17 commented May 12, 2022

Issue unable to reproduce for me on staging. @Tushu17 can you confirm the same?

@Santhosh-Sellavel yup, It's no more reproducible.

@roryabraham
Copy link
Contributor

@arielgreen Closing this out. Please pay @Tushu17 for the reporting bonus.

@roryabraham roryabraham reopened this May 17, 2022
@roryabraham
Copy link
Contributor

Actually, I'll leave this open for you and just unassign myself

@roryabraham roryabraham removed the Help Wanted Apply this label when an issue is open to proposals by contributors label May 17, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 17, 2022

📣 @Santhosh-Sellavel You have been assigned to this job by @roryabraham!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@roryabraham
Copy link
Contributor

My mistake, @Santhosh-Sellavel is also eligible for C+ compensation for reviewing #8576, even though it wasn't merged.

@melvin-bot melvin-bot bot added the Overdue label May 26, 2022
@arielgreen
Copy link
Contributor

@Tushu17 and @Santhosh-Sellavel just sent over offers to both of you via Upwork, once you accept I will pay out the job and close the issue.

@melvin-bot melvin-bot bot removed the Overdue label May 27, 2022
@Tushu17
Copy link
Contributor

Tushu17 commented May 27, 2022

@arielgreen Thank you, Offer accepted.

@Santhosh-Sellavel
Copy link
Collaborator

@arielgreen
Accepted the offer, thanks!

@Santhosh-Sellavel
Copy link
Collaborator

@arielgreen Just waiting for payment here, Please close this out after issuing payout thanks!

@arielgreen
Copy link
Contributor

Paid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arielgreen arielgreen

@Santhosh-Sellavel Santhosh-Sellavel

Labels
Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@jayeshmangwani @arielgreen @mvtglobally @muttmuure @roryabraham @nadir @Santhosh-Sellavel @Tushu17