[HOLD for payment 2022-07-15] [$250] Web - Request money - Five most recent chats aren't shown correctly

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Pre-Condition: Have a couple/several chats already open with other accounts

1. Access http://staging.new.expensify.com
2. Log in to a high traffic account
3. Click on the green "Plus" icon on the right side of chat history
4. Click on "Request Money"
5. Enter any amount in Big Number Pad (BNP) and any currency (For example: 1 Real)
6. Click green "Next" button

Expected Result:

The user expects to see five most recent chats appear under the Recents header (Excluding group chats and concierge chat)

Actual Result:

The user sees five chats in this section, however they are not the five most recent chats. There is one chat that should not be placed within this list

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.44.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester: applausetester+ebezerra@applause.expensifail.com

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.82.mp4

Bug5495612_Request.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[dylanexpensify]

Internal: https://www.upwork.com/ab/applicants/1505963684490752000/job-details
External: https://www.upwork.com/jobs/~01916b2d3a4c68ba01

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

[MelvinBot]

📣 @parasharrajat You have been assigned to this job by @melvin-bot[bot]!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Current assignee @roryabraham is eligible for the Exported assigner, not assigning anyone new.

[metehanozyurt]

Proposal

Cause

IOUParticipantsRequest component calls getNewChatOptions from OptionsListUtils, and it calls getOptions function which sorts contacts by lastVisitedTimestamp by default.

Solution

We should pass sortByLastMessageTimestamp parameter through these functions:

• getNewChatOptions
• getSearchOptions (This will change order of the new chat search order also, if this is wanted)
• getOptions (Already takes sortByLastMessageTimestamp as a parameter)

To do this we should take sortByLastMessageTimestamp as a parameter and pass it to the getOptions in the following functions in OptionsListUtils:

function getSearchOptions(  
    reports,  
    personalDetails,  
    searchValue = '',  
    betas,  
    sortByLastMessageTimestamp = false,  
) {  
    return getOptions(reports, personalDetails, 0, {  
        betas,  
        searchValue: searchValue.trim(),  
        includeRecentReports: true,  
        includeMultipleParticipantReports: true,  
        maxRecentReportsToShow: 0, // Unlimited  
  prioritizePinnedReports: false,  
        prioritizeDefaultRoomsInSearch: false,  
        sortByReportTypeInSearch: true,  
        showChatPreviewLine: true,  
        showReportsWithNoComments: true,  
        includePersonalDetails: true,  
        sortByLastMessageTimestamp: !!sortByLastMessageTimestamp,  
        forcePolicyNamePreview: true,  
        prioritizeIOUDebts: false,  
    });  
}

// ...

function getNewChatOptions(  
    reports,  
    personalDetails,  
    betas = [],  
    searchValue = '',  
    selectedOptions = [],  
    excludeLogins = [],  
    sortByLastMessageTimestamp = false,  
) {  
    return getOptions(reports, personalDetails, 0, {  
        betas,  
        searchValue: searchValue.trim(),  
        selectedOptions,  
        excludeDefaultRooms: true,  
        includeRecentReports: true,  
        includePersonalDetails: true,  
        maxRecentReportsToShow: 5,  
        excludeLogins,  
        sortByLastMessageTimestamp,  
    });  
}

We should update OptionsListUtils.getNewChatOptions function call with the new parameter in the constructor of IOUParticipantsRequest component:

constructor(props) {  
    super(props);  
  
    this.addSingleParticipant = this.addSingleParticipant.bind(this);  
  
    const {  
        recentReports,  
        personalDetails,  
        userToInvite,  
    } = OptionsListUtils.getNewChatOptions(  
        props.reports,  
        props.personalDetails,  
        props.betas,  
        '',  
        [],  
        CONST.EXPENSIFY_EMAILS,  
        true, // New parameter
    );  
  
    this.state = {  
        recentReports,  
        personalDetails,  
        userToInvite,  
        searchValue: '',  
    };  
}

Before ;

20220328_012133.mp4

After Fix issue ;

20220328_012243.mp4

[parasharrajat]

@metehanozyurt's proposal looks good to me.

cc: @roryabraham

Rory, Do we need the same behavior everywhere where we are showing newChat Contacts?

If so, we will not have to add another param to OptionsListUtils.getNewChatOptions. It will just modify the call to getOptions in the above proposal.

🎀 👀 🎀 C+ reviewed

[roryabraham]

@metehanozyurt's proposal looks good, but I am unwilling to approve any proposal or PR that touches OptionsListUtils without also creating unit tests to cover the change.

@metehanozyurt If you agree to also create unit tests, 👍 this message and I will assign you the job.

[parasharrajat]

Oh, yeah. I was thinking the same just forgot to ask here.

[dylanexpensify]

Checking in, seems we will have someone for the job @parasharrajat? Just checking in case we need to double the price

[parasharrajat]

No need to double. we are good here.

[metehanozyurt]

Hi @parasharrajat and @roryabraham. I add some tests to OptionsListUtilsTest. Hope you like it.

I'm sorry for being late. I wrote before, but I was very nervous because the results I wanted did not come out. Then I noticed that the 'lastMessageTimestamp' values ​​were entered the same value in test file. Then i check the other results too. I wrote test for 'getSearchOptions' and 'getNewChatOptions' functions.

here edited OptionsListUtilsTest file

https://github.com/metehanozyurt/testFile/blob/main/OptionsListUtilsTest.js

I know this issue title about 'Request money' issue but when it will fixed 'Split Money' , 'New Chat' and 'New Group' isues can came up again.

When we change this file (IOUParticipantsRequest), other files will sort differently.
IOUParticipantsSplit, NewChatPage,

i can set the parameter if you want.

before ;

20220402_172031.mp4

after

20220402_174322.mp4

[dylanexpensify]

@parasharrajat still good with where we are here on price?

[parasharrajat]

@dylanexpensify If we are good to hire the selected proposal then I don't think a price increase is needed.

[parasharrajat]

@metehanozyurt I didn't understand this post #8220 (comment). Could you please try to rephrase it?

Are you trying to say that, your proposed solution does not have desired results?

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[NicMendonca]

deployed to staging, so will be ready for payment soon

[JmillsExpensify]

Great thanks! I'll handle the payment once we clear the regression period.

[JmillsExpensify]

This issue might be affected by the late production deploy. PR still isn't showing we're in the regression period.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.79-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Request money - Five most recent chats aren't shown correctly #8549

If no regressions arise, payment will be issued on 2022-07-15. 🎊

[mvtglobally]

Issue not reproducible during KI retests. (Third week)

[JmillsExpensify]

Almost through the regression period following the production deploy last week.

[roryabraham]

Looks like we're just awaiting payment here

[mvtglobally]

Issue not reproducible during KI retests. (4th week)

[JmillsExpensify]

@roryabraham yes indeed. I just took a look at the Upwork, and we actually still need to hire contributors. I'm going to jump in and send offers now, such that when I'm up tomorrow contracts will be accepted and I can issue payments.

[JmillsExpensify]

Ah, the saga continues! Looks like the previous post from above is already expired. I've created a fresh one here: https://www.upwork.com/jobs/~01a80e9993680dc31b. @parasharrajat @metehanozyurt I've already invited you both to the job. Please accept and we'll get this processed for you both pronto.

[metehanozyurt]

Thank you for invitation @JmillsExpensify . There was something I wanted to talk about. It was bonus for this job, I wonder if I can still get it. Thanks.
#8220 (comment)

[JmillsExpensify]

@metehanozyurt Yes absolutely. Thank you so much for pointing that out. I've sent the updated offer (same for @parasharrajat). I'll be on later this evening so maybe we'll cross paths and we can close this out!

[JmillsExpensify]

Thanks both for your patience. I've issued payments in Upwork, so I'm closing out this issue. Please reach out if we've missed something.