Remove Save button on default rooms settings

[kevinksullivan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Join defaultRooms beta
2. See default room - either #announce or #admins
3. Click room avatar
4. Click settings

Expected Result:

There should be no Save button on the room name, and the field should be clearly non-editable (i.e. no text box around it)

Actual Result:

The field looks editable and has a Save button

Platform:

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Notes/Photos/Videos:

Slack conversation: https://expensify.slack.com/archives/C02MW39LT9N/p1646421753395089?thread_ts=1646419035.253859&cid=C02MW39LT9N

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @kadiealexander (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[kevinksullivan]

CC @Expensify/design @trjExpensify want to make sure you're all good with this change too!

[trjExpensify]

Yep agreed, as you can't edit the name of a default room.

[shawnborton]

cc @parasharrajat I think we were working together on this kind of input recently? Anyways I agree in that we should get rid of the save button, but I think I would also use a style more like the bottom example in terms of how to display this since it is read-only:

[MelvinBot]

Triggered auto assignment to @nickmurray47 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[parasharrajat]

Yeah, So the Attached screenshot on the issue details is old. New Style is already merged but not yet available on PROD.

To reflect the read-only input, we have a grayish background color and the rest of the input is the same. This is the same for all inputs in the App.

But instead of trying to keep the same input design as the last one on this image, I suggest we use the normal Header and details section style.

So Image will have Room Name header and underneath #announce as content. Like this

[shawnborton]

I think I disagree with your comment about the header style. I know it's still a bit of a work in progress, but we are actively trying to update our inputs to the style that I shared above.

[nickmurray47]

@parasharrajat if you were working on a similar issue, do you mind linking me the PR?

Correct me if I'm wrong it sounds like the update here will not be for the "Save" button, but just around the header style.

[shawnborton]

Yeah apologies for the confusion, I kind of distracted from the original post here. I think we need to remove the Save button, and then furthermore I am suggesting that we change the style of the input when it is read-only.

[shawnborton]

Looking at a recent mockup, I think all of these small headers can be removed as they are redundant:

The bottom "Workspace" should look like the disabled input style I am suggesting in my post above.

[nickmurray47]

got it, seems like a small enough issue that I can just whip up a quick PR and will tag you in it for style check when it's ready @shawnborton

[shawnborton]

Sounds great, thanks!

[MelvinBot]

@nickmurray47 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

@nickmurray47 Eep! 4 days overdue now. Issues have feelings too...

[MelvinBot]

@nickmurray47 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!