[$62.50] The filter bar on Search page contains the wrong icons when set to Chat #57763

m-natarajan · 2025-03-04T15:29:19Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.1.8-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dubielzyk-expensify
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

Navigate to Report search
Select Chat
Observe the Icons for Attachments and Links for the sort options

Expected Result:

The icons should be as outlined in the design document

Actual Result:

The icons are not as per the design document

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021897406334382928419
Upwork Job ID: 1897406334382928419
Last Price Increase: 2025-03-05
Automatic offers:

brunovjk | Reviewer | 106462338

Issue Owner

Current Issue Owner: @brunovjk

melvin-bot · 2025-03-04T15:29:30Z

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

m-natarajan · 2025-03-04T15:30:07Z

Proposal by @shubham1206agra

Proposal

Please re-state the problem that we are trying to solve in this issue.

The filter bar on Search page contains the wrong icons when set to Chat

What is the root cause of that problem?

Design Change Request

What changes do you think we should make in order to solve the problem?

Change icons in following places to whatever is required in the issue

App/src/components/Search/SearchPageHeader/SearchStatusBar.tsx

Line 130 in b649380

icon: Expensicons.Document,
App/src/components/Search/SearchPageHeader/SearchStatusBar.tsx

Line 136 in b649380

icon: Expensicons.Paperclip,

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Not Required as this is a simple icon change

What alternative solutions did you explore? (Optional)

melvin-bot · 2025-03-05T21:58:18Z

Job added to Upwork: https://www.upwork.com/jobs/~021897406334382928419

melvin-bot · 2025-03-05T21:58:25Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

brunovjk · 2025-03-06T10:25:55Z

I'm working on some PRs review now, I'm going to review the proposal ASAP. Thank you.

mkaushik969 · 2025-03-06T10:52:10Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The filter bar on Search page contains the wrong icons when set to Chat

What is the root cause of that problem?

Wrong icon assigned to "Attachments" and "Links" filter options

What changes do you think we should make in order to solve the problem?

Change the icons as following:

App/src/components/Search/SearchPageHeader/SearchStatusBar.tsx

Lines 128 to 131 in b649380

    
           type: CONST.SEARCH.DATA_TYPES.CHAT, 
        
           status: CONST.SEARCH.STATUS.CHAT.ATTACHMENTS, 
        
           icon: Expensicons.Document, 
        
           text: 'common.attachments',

to icon: Expensicons.Paperclip

App/src/components/Search/SearchPageHeader/SearchStatusBar.tsx

Lines 134 to 137 in b649380

    
           type: CONST.SEARCH.DATA_TYPES.CHAT, 
        
           status: CONST.SEARCH.STATUS.CHAT.LINKS, 
        
           icon: Expensicons.Paperclip, 
        
           text: 'common.links',

to icon: Expensicons.Link

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

brunovjk · 2025-03-06T19:30:16Z

@shubham1206agra's proposal looks fine to me. I wonder if there are other icons we should check, as this bug seems to have been in the prod for some time, I haven't found any yet.

🎀👀🎀 C+ reviewed

melvin-bot · 2025-03-06T19:30:30Z

Triggered auto assignment to @roryabraham, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot · 2025-03-10T10:31:17Z

@brunovjk Whoops! This issue is 2 days overdue. Let's get this updated quick!

brunovjk · 2025-03-10T10:47:05Z

Friendly bump @roryabraham on Slack

melvin-bot · 2025-03-10T16:03:04Z

📣 @brunovjk 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

roryabraham · 2025-03-10T16:03:51Z

just wanted to clarify that the price for this issue is intended to be $62.50, not $250

shubham1206agra · 2025-03-10T16:05:43Z

@roryabraham Can you keep this at $100?

shubham1206agra · 2025-03-10T16:06:41Z

@Expensify/design Can you send the attachment icon?

dannymcclain · 2025-03-10T16:14:59Z

The icons are here:

Attachment: App/assets/images/paperclip.svg
Link: App/assets/images/link.svg

m-natarajan added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Mar 4, 2025

melvin-bot bot assigned greg-schroeder Mar 4, 2025

greg-schroeder added this to [#whatsnext] #quality Mar 5, 2025

greg-schroeder moved this to LOW in [#whatsnext] #quality Mar 5, 2025

greg-schroeder changed the title ~~The filter bar on Search page contains the wrong icons when set to Chat~~ [$62.50] The filter bar on Search page contains the wrong icons when set to Chat Mar 5, 2025

greg-schroeder added the External Added to denote the issue can be worked on by a contributor label Mar 5, 2025

melvin-bot bot changed the title ~~[$62.50] The filter bar on Search page contains the wrong icons when set to Chat~~ [$250] [$62.50] The filter bar on Search page contains the wrong icons when set to Chat Mar 5, 2025

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 5, 2025

melvin-bot bot assigned brunovjk Mar 5, 2025

melvin-bot bot assigned roryabraham Mar 6, 2025

melvin-bot bot added the Overdue label Mar 10, 2025

melvin-bot bot removed the Overdue label Mar 10, 2025

roryabraham assigned shubham1206agra Mar 10, 2025

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 10, 2025

roryabraham changed the title ~~[$250] [$62.50] The filter bar on Search page contains the wrong icons when set to Chat~~ [$62.50] The filter bar on Search page contains the wrong icons when set to Chat Mar 10, 2025

shubham1206agra mentioned this issue Mar 10, 2025

Fixed attachment and link icon in chat search #58109

Open

49 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Mar 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[$62.50] The filter bar on Search page contains the wrong icons when set to Chat #57763

[$62.50] The filter bar on Search page contains the wrong icons when set to Chat #57763

m-natarajan commented Mar 4, 2025 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Mar 4, 2025

m-natarajan commented Mar 4, 2025

melvin-bot bot commented Mar 5, 2025

melvin-bot bot commented Mar 5, 2025

brunovjk commented Mar 6, 2025

mkaushik969 commented Mar 6, 2025

brunovjk commented Mar 6, 2025 •

edited

Loading

melvin-bot bot commented Mar 6, 2025

melvin-bot bot commented Mar 10, 2025

brunovjk commented Mar 10, 2025

melvin-bot bot commented Mar 10, 2025

roryabraham commented Mar 10, 2025

shubham1206agra commented Mar 10, 2025

shubham1206agra commented Mar 10, 2025

dannymcclain commented Mar 10, 2025 •

edited

Loading

[$62.50] The filter bar on Search page contains the wrong icons when set to Chat #57763

[$62.50] The filter bar on Search page contains the wrong icons when set to Chat #57763

Comments

m-natarajan commented Mar 4, 2025 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Mar 4, 2025

m-natarajan commented Mar 4, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Mar 5, 2025

melvin-bot bot commented Mar 5, 2025

brunovjk commented Mar 6, 2025

mkaushik969 commented Mar 6, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

brunovjk commented Mar 6, 2025 • edited Loading

melvin-bot bot commented Mar 6, 2025

melvin-bot bot commented Mar 10, 2025

brunovjk commented Mar 10, 2025

melvin-bot bot commented Mar 10, 2025

roryabraham commented Mar 10, 2025

shubham1206agra commented Mar 10, 2025

shubham1206agra commented Mar 10, 2025

dannymcclain commented Mar 10, 2025 • edited Loading

m-natarajan commented Mar 4, 2025 •

edited by melvin-bot bot

Loading

brunovjk commented Mar 6, 2025 •

edited

Loading

dannymcclain commented Mar 10, 2025 •

edited

Loading