[$250] Duplicate paid adoption events are logged each time a payment card is added

[arosiclair]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.60-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): All
Logs: N/A
Expensify/Expensify Issue URL: N/A
Issue reported by: @arosiclair
Slack conversation (hyperlinked to channel name): https://expensify.slack.com/archives/C07HPDRELLD/p1739905840251309

Action Performed:

1. Sign into NewDot with a new admin account
2. Go to Avatar > Subscription
3. Add a payment card
4. Select Change payment card in the card's 3-dot menu
5. Enter new details and submit

Expected Result:

[info] [GTM] event published - {"event":"paid_adoption","user_id":###} is NOT logged in the console since it's not the first payment card

Actual Result:

The event is logged

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021892259730792067530
• Upwork Job ID: 1892259730792067530
• Last Price Increase: 2025-02-19
• Automatic offers:
• nkdengineer | Contributor | 106206679

Issue Owner

Current Issue Owner: @rushatgabhane

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[arosiclair]

The add/change flows are slightly different so we should be able to just fix this on the frontend.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021892259730792067530

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Duplicate paid adoption events are logged each time a payment card is added

What is the root cause of that problem?

when we Change payment card we will navigate to route SETTINGS_SUBSCRIPTION_ADD_PAYMENT_CARD and call function addSubscriptionPaymentCard here

App/src/pages/settings/Subscription/CardSection/CardSectionActions/index.tsx

Lines 28 to 32 in 220c69f

	{
	icon: Expensicons.CreditCard,
	text: translate('subscription.cardSection.changeCard'),
	onSelected: () => Navigation.navigate(ROUTES.SETTINGS_SUBSCRIPTION_ADD_PAYMENT_CARD),
	},

App/src/pages/settings/Subscription/PaymentCard/index.tsx

Line 59 in bf23769

PaymentMethods.addSubscriptionPaymentCard(accountID ?? 0, cardData);

and in the addSubscriptionPaymentCard function we are logging without distinguishing between creating new or changing here

App/src/libs/actions/PaymentMethods.ts

Line 276 in 220c69f

GoogleTagManager.publishEvent(CONST.ANALYTICS.EVENT.PAID_ADOPTION, accountID);

What changes do you think we should make in order to solve the problem?

We can rely on the Onyx key FUND_LIST to see if we are creating a new card or changing to a different card.

If change to another card, will not log here anymore and will add new log Log.info('[GTM] Not logging paid_adoption because a card was already added');.

App/src/libs/actions/PaymentMethods.ts

Line 276 in 220c69f

GoogleTagManager.publishEvent(CONST.ANALYTICS.EVENT.PAID_ADOPTION, accountID);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[rushatgabhane]

@nkdengineer's proposal LGMT 🎀👀🎀

#57122 (comment)

[melvin-bot]

Current assignee @arosiclair is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[rushatgabhane]

@nkdengineer could you please where are we calling the function addSubscriptionPaymentCard on navigation?

[arosiclair]

@nkdengineer another requirement: we should log when we are not publishing the event so it's easier to debug later. Eg: [GTM] Not logging paid_adoption because a card was already added

[nkdengineer]

@arosiclair @rushatgabhane updated proposal

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[nkdengineer]

@rushatgabhane @arosiclair We have a draft PR here.
But as mentioned in this issue, we need to use an internal Expensify engineer's ngrok credentials in order to test this. @arosiclair could you help me here or can we skip the testing step?

You will need to use an internal Expensify engineer's ngrok credentials in order to test this. If you'd like to work on this please message @blimpich and I will provide you with instructions on how to use my local backend via ngrok.

[arosiclair]

@nkdengineer can you add a test to GoogleTagManagerTest instead? That should be enough.

[nkdengineer]

thanks @arosiclair, I'll open PR today

[nkdengineer]

@rushatgabhane @arosiclair we have a open PR here

[maddylewis]

@rushatgabhane @arosiclair - will you take a look at the PR for this one when you have a chance? tysm!

[arosiclair]

It's merged already. We're just waiting on the deploy to prod.