[$250] Scan – RBR is not displayed in LHN when editing an amount to be higher than the scanned amount

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.0-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/3212423
Email or phone of affected tester (no customers): testpayment935@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome, Samsung s10/ Chrome, Samsung s10/ Android 12
App Component: Money Requests

Action Performed:

Prerequisite
Have a workspace and invite a member (Employee) to the workspace

1. As the employee navigate to the workspace chat
2. Click on + icon > Submit expense > Scan
3. Upload a digital receipt > Submit > Wait for the smart scan to be completed
4. Once the smart scan is finished navigate to the expense details
5. Click on the amount > edit the amount to be higher than the scanned amount > Save
6. Notice that after a while a violation is displayed indicating the amount is higher than the scanned receipt
7. Now observe the LHN of the workspace chat

Expected Result:

RBR is displayed in the expense and LHN

Actual Result:

RBR is not displayed in LHN

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6746612_1739879508859.bandicam_2025-02-18_14-50-56-703.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021894305927253108037
• Upwork Job ID: 1894305927253108037
• Last Price Increase: 2025-02-25
• Automatic offers:
• FitseTLT | Contributor | 106362085

Issue Owner

Current Issue Owner: @rojiphil

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-18 12:49:18 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Scan – RBR is not displayed in LHN when editing an amount to be higher than the scanned amount

What is the root cause of that problem?

We missed notice type violations here

App/src/libs/ReportUtils.ts

Line 6957 in 84885ab

return hasViolations(potentialReport.reportID, transactionViolations) || hasWarningTypeViolations(potentialReport.reportID, transactionViolations);

What changes do you think we should make in order to solve the problem?

We need to consider notice type violations here

App/src/libs/ReportUtils.ts

Line 6957 in 84885ab

return hasViolations(potentialReport.reportID, transactionViolations) || hasWarningTypeViolations(potentialReport.reportID, transactionViolations);

            hasViolations(potentialReport.reportID, transactionViolations) ||
            hasWarningTypeViolations(potentialReport.reportID, transactionViolations) ||
            hasNoticeTypeViolations(potentialReport.reportID, transactionViolations)
        );

If needed to be consistent with report preview here we can optionally pass shouldShowInReview param as true.
Note: There are also more inconsistencies in LHN RBR compared to the ReportPreview RBR logic here we also have missed smart scanning errors so we can also handle those missed cases to in the PR (similarly with MoneyRequestPreview which shows rbr for held transactions).

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Add test for shouldDisplayViolationsRBRInLHN to assert that it handles notice type violations too

What alternative solutions did you explore? (Optional)

[RachCHopkins]

Will triage asap

[RachCHopkins]

Can confirm the result. Weirdly, I had another chat that has RBR and I fixed the issue on that and it also did not update in the LHN. There is also nothing in the workspace chat that indicates an issue:

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021894305927253108037

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[melvin-bot]

@rojiphil Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[rojiphil]

@FitseTLT proposal LGTM. i.e. to add notice-type violations to resolve the issue here. Also, as mentioned, let us be consistent with the LHN and report preview RBR logic
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖