[$250] [Due for payment 2025-02-25] [Navigation] Workspace - Unable to invite member from Overview

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.98-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sj9032@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Overview.
3. Click Invite.
4. Click a member > Next.
5. Click Invite.

Expected Result:

Member is invited successfully.

Actual Result:

Nothing happens after clicking Invite button.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6741304_1739401124685.20250213_065715.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021892145417207271540
• Upwork Job ID: 1892145417207271540
• Last Price Increase: 2025-02-19

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Nothing happens after clicking Invite button.

What is the root cause of that problem?

We added Navigation.dismissModal(); in this commit to fix error when press ESC button

but the problem is that we are using 2 navigates in a row here

App/src/pages/workspace/WorkspaceInviteMessagePage.tsx

Lines 115 to 119 in a0a2609

	Navigation.setNavigationActionToMicrotaskQueue(() => {
	Navigation.dismissModal();
	Navigation.navigate(ROUTES.WORKSPACE_MEMBERS.getRoute(route.params.policyID));
	});
	};

What changes do you think we should make in order to solve the problem?

We can add InteractionManager.runAfterInteractions for the second navigate

        Navigation.setNavigationActionToMicrotaskQueue(() => {
            Navigation.dismissModal();
            InteractionManager.runAfterInteractions(() => {
                Navigation.navigate(ROUTES.WORKSPACE_MEMBERS.getRoute(route.params.policyID));
            });
        });

App/src/pages/workspace/WorkspaceInviteMessagePage.tsx

Lines 115 to 119 in a0a2609

	Navigation.setNavigationActionToMicrotaskQueue(() => {
	Navigation.dismissModal();
	Navigation.navigate(ROUTES.WORKSPACE_MEMBERS.getRoute(route.params.policyID));
	});
	};

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

OR we can remove Navigation.dismissModal(); here

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[mountiny]

FYI most likely related to https://expensify.slack.com/archives/C01GTK53T8Q/p1739435484596829?thread_ts=1739328522.587109&cid=C01GTK53T8Q and we are discussing and working on solutions for this

[adamgrzybowski]

@mountiny Yeah that's makes sense

[adamgrzybowski]

@mountiny Just to make it clear 😄 this proposal is good 🟢.
We may want to find a better system approach for problems like that in the future.

[mountiny]

🟢 green colour I understand 🙌

[mountiny]

Also no payment required so closing

[nkdengineer]

@mountiny I was assigned to this issue and created a PR that was merged here. Should i get payment on this one?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021892145417207271540

[melvin-bot]

Current assignee @dukenv0307 is eligible for the External assigner, not assigning anyone new.

[mountiny]

Whoops sorry, I thought this was fixed by swm, thanks!

[mountiny]

$250 to @nkdengineer only. @dukenv0307 reviewed the original PR

[zanyrenney]

@mountiny when is payment due? the title says not for 4 more days but is that correct?

[mountiny]

Looks good to me based on the PR deployment time

[zanyrenney]

@nkdengineer i invited you to the upwork job as you had not applied: https://www.upwork.com/ab/applicants/1892145417207271540/pending

[nkdengineer]

@zanyrenney Applied to the job, thank you

[zanyrenney]

perfect thanks!

[zanyrenney]

offer is pending, please accept!

[zanyrenney]

cc @nkdengineer

[zanyrenney]

payment summary

$250 paid to @nkdengineer via upwork.