Skip to content

Commit a0a2609

Browse files
authored
Merge pull request #56757 from huult/revert-pull-request-56316
2 parents fb2eb3f + e754b44 commit a0a2609

File tree

3 files changed

+13
-45
lines changed

3 files changed

+13
-45
lines changed

src/languages/en.ts

-1
Original file line numberDiff line numberDiff line change
@@ -2720,7 +2720,6 @@ const translations = {
27202720
submitExpense: 'Submit your expenses below:',
27212721
defaultCategory: 'Default category',
27222722
viewTransactions: 'View transactions',
2723-
leaveConfirmation: "Are you sure you want to leave this workspace? Once you leave, you'll lose access to all data and settings associated with this workspace.",
27242723
},
27252724
perDiem: {
27262725
subtitle: 'Set per diem rates to control daily employee spend. ',

src/languages/es.ts

-2
Original file line numberDiff line numberDiff line change
@@ -2745,8 +2745,6 @@ const translations = {
27452745
submitExpense: 'Envía tus gastos a continuación:',
27462746
defaultCategory: 'Categoría predeterminada',
27472747
viewTransactions: 'Ver transacciones',
2748-
leaveConfirmation:
2749-
'¿Estás seguro de que quieres salir de este espacio de trabajo? Una vez que salgas, perderás el acceso a todos los datos y configuraciones asociadas con este espacio de trabajo.',
27502748
},
27512749
perDiem: {
27522750
subtitle: 'Establece las tasas per diem para controlar los gastos diarios de los empleados. ',

src/pages/workspace/WorkspaceProfilePage.tsx

+13-42
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import useResponsiveLayout from '@hooks/useResponsiveLayout';
2020
import useThemeIllustrations from '@hooks/useThemeIllustrations';
2121
import useThemeStyles from '@hooks/useThemeStyles';
2222
import {clearInviteDraft} from '@libs/actions/Policy/Member';
23-
import {clearAvatarErrors, clearPolicyErrorField, deleteWorkspace, deleteWorkspaceAvatar, leaveWorkspace, openPolicyProfilePage, updateWorkspaceAvatar} from '@libs/actions/Policy/Policy';
23+
import {clearAvatarErrors, clearPolicyErrorField, deleteWorkspace, deleteWorkspaceAvatar, openPolicyProfilePage, updateWorkspaceAvatar} from '@libs/actions/Policy/Policy';
2424
import {getLatestErrorField} from '@libs/ErrorUtils';
2525
import resetPolicyIDInNavigationState from '@libs/Navigation/helpers/resetPolicyIDInNavigationState';
2626
import Navigation from '@libs/Navigation/Navigation';
@@ -49,7 +49,6 @@ function WorkspaceProfilePage({policyDraft, policy: policyProp, route}: Workspac
4949
const illustrations = useThemeIllustrations();
5050
const {canUseSpotnanaTravel} = usePermissions();
5151
const {activeWorkspaceID, setActiveWorkspaceID} = useActiveWorkspace();
52-
const [isLeaveModalOpen, setIsLeaveModalOpen] = useState(false);
5352

5453
const [currencyList = {}] = useOnyx(ONYXKEYS.CURRENCY_LIST);
5554
const [currentUserAccountID = -1] = useOnyx(ONYXKEYS.SESSION, {selector: (session) => session?.accountID});
@@ -157,28 +156,20 @@ function WorkspaceProfilePage({policyDraft, policy: policyProp, route}: Workspac
157156

158157
const [isDeleteModalOpen, setIsDeleteModalOpen] = useState(false);
159158

160-
const handleWorkspaceAction = useCallback(
161-
(action: 'delete' | 'leave') => {
162-
if (!policy?.id || !policyName) {
163-
return;
164-
}
165-
166-
if (action === 'delete') {
167-
deleteWorkspace(policy.id, policyName);
168-
setIsDeleteModalOpen(false);
169-
} else {
170-
leaveWorkspace(policy.id);
171-
}
159+
const confirmDeleteAndHideModal = useCallback(() => {
160+
if (!policy?.id || !policyName) {
161+
return;
162+
}
172163

173-
if (activeWorkspaceID !== policy?.id) {
174-
return;
175-
}
164+
deleteWorkspace(policy.id, policyName);
165+
setIsDeleteModalOpen(false);
176166

167+
// If the workspace being deleted is the active workspace, switch to the "All Workspaces" view
168+
if (activeWorkspaceID === policy.id) {
177169
setActiveWorkspaceID(undefined);
178170
resetPolicyIDInNavigationState();
179-
},
180-
[policy?.id, policyName, activeWorkspaceID, setActiveWorkspaceID],
181-
);
171+
}
172+
}, [policy?.id, policyName, activeWorkspaceID, setActiveWorkspaceID]);
182173

183174
return (
184175
<WorkspacePageWithSections
@@ -226,7 +217,7 @@ function WorkspaceProfilePage({policyDraft, policy: policyProp, route}: Workspac
226217
styles.sectionMenuItemTopDescription,
227218
]}
228219
editIconStyle={styles.smallEditIconWorkspace}
229-
isUsingDefaultAvatar={!policy?.avatarURL}
220+
isUsingDefaultAvatar={!policy?.avatarURL ?? false}
230221
onImageSelected={(file) => {
231222
if (!policy?.id) {
232223
return;
@@ -370,37 +361,17 @@ function WorkspaceProfilePage({policyDraft, policy: policyProp, route}: Workspac
370361
)}
371362
</View>
372363
)}
373-
{!(isPolicyAdmin || isOwner) && (
374-
<View style={[styles.flexRow, styles.mt6, styles.mnw120]}>
375-
<Button
376-
accessibilityLabel={translate('common.leave')}
377-
text={translate('common.leave')}
378-
onPress={() => setIsLeaveModalOpen(true)}
379-
icon={Expensicons.Exit}
380-
/>
381-
</View>
382-
)}
383364
</Section>
384365
<ConfirmModal
385366
title={translate('workspace.common.delete')}
386367
isVisible={isDeleteModalOpen}
387-
onConfirm={() => handleWorkspaceAction('delete')}
368+
onConfirm={confirmDeleteAndHideModal}
388369
onCancel={() => setIsDeleteModalOpen(false)}
389370
prompt={hasCardFeedOrExpensifyCard ? translate('workspace.common.deleteWithCardsConfirmation') : translate('workspace.common.deleteConfirmation')}
390371
confirmText={translate('common.delete')}
391372
cancelText={translate('common.cancel')}
392373
danger
393374
/>
394-
<ConfirmModal
395-
title={translate('common.leave')}
396-
isVisible={isLeaveModalOpen}
397-
onConfirm={() => handleWorkspaceAction('leave')}
398-
onCancel={() => setIsLeaveModalOpen(false)}
399-
prompt={translate('workspace.common.leaveConfirmation')}
400-
confirmText={translate('common.leave')}
401-
cancelText={translate('common.cancel')}
402-
danger
403-
/>
404375
</View>
405376
)}
406377
</WorkspacePageWithSections>

0 commit comments

Comments
 (0)